* Antoine Jacoutot <ajacoutot@bsdfrog.org> wrote:
>On Sun, Jul 02, 2017 at 04:38:49PM +0100, Edd Barrett wrote:
>> Hi Jon,
>>
>> On Tue, May 02, 2017 at 09:51:57AM -0400, Jon Bernard wrote:
>> > This is my first port, I think everything is in order from what I've
>> > read but do let me know if I've missed or misunderstood something.
>>
>> Here are a few comments:
>>
>> * You need to mark the port as not having tests (see NO_TEST).
>>
>> * You are missing a WANTLIB line. There's a make target
>> 'port-lib-depends-check' that can help you.
>>
>> * Funny that they have an install target which installs the manual, but
>> not the binary! Doh! Might want to report that, so that in later
>> versions you don't need a custom do-install target.
>
>They do install the binary.
>You just need to specify proper variables:
>MAKE_FLAGS = PREFIX=${PREFIX} \
> MANDIR="/man/man1"
I'm not sure what I was thinking.. You're right, thanks for pointing this out.
--
Jon
>> * You should set a HOMEPAGE, even if it's just the GitHub landing page.
>
>There is already one, thanks to the GH_* veriables:
>$ make show=HOMEPAGE
>https://github.com/alols/xcape
>
>> The tool seems to work. With xcape running in the default config, left
>> control sends escape.
>>
>> Fix up the above and send a new tarball and I will see if we can put
>> this in for you :)
>>
>> Thanks
>>
>> --
>> Best Regards
>> Edd Barrett
>>
>> http://www.theunixzoo.co.uk
>>
>
>--
>Antoine
>
No comments:
Post a Comment