Jeremie Courreges-Anglas <jca@wxcvbn.org> writes:
> Daniel Jakots <danj+obsd@chown.me> writes:
>
>> Hi,
>>
>> This duplicity update has a new RDEP (py-fasteners) which itself needs
>> another new RDEP (py-monotonic).
>>
>> Changelog is mainly bugfixes and 0.7.13.1 is a bugfix release for Mac
>> according to changelog.
>>
>> Testing the whole is appreciated if you can.
>>
>> Comments? Nitpick over pkg/DESCR? OK?
>
> About py-monotonic:
> - I'd say Apache *2.0* in the license marker
> - drop trailing colon in DESCR
> - monotonic.py's fallback assumes that time_t is a long, ie 32 bits on
> 32 bits platforms. Doesn't work for us, for example with python2.7 on
> armv7, monotonic.monotonic() will return "40.0", "41.0", "42.0" and so
> on, which means that we're losing the fractional part.
>
> Updated tarball attached, ok to import if you like it.
I'd also suggest to use the homepage defined in setup.py, ie
https://github.com/atdt/monotonic
--
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
No comments:
Post a Comment