On 2018/01/20 16:28, Jonathan Gray wrote:
> With armv7 switching to clang as the base compiler atomic builtins and
> -mfpu=neon are now available on arm.
Comments on a couple below, others are OK with me:
> Index: lang/racket-minimal/Makefile
> ===================================================================
> RCS file: /cvs/ports/lang/racket-minimal/Makefile,v
> retrieving revision 1.43
> diff -u -p -r1.43 Makefile
> --- lang/racket-minimal/Makefile 2 Dec 2017 21:39:49 -0000 1.43
> +++ lang/racket-minimal/Makefile 20 Jan 2018 00:52:42 -0000
> @@ -38,7 +38,6 @@ EXTRACT_SUFX = .tgz
> # "places" and "futures" require TLS.
> COMPILER = base-clang ports-gcc
> COMPILER_LANGS = c
> -MODGCC4_ARCHS = arm
>
> LIB_DEPENDS = converters/libiconv \
> databases/sqlite3 \
Here ports-gcc is only used for arm (restricting from the defaults).
By removing MODGCC4_ARCHS all !base-clang arches switch to ports-gcc,
so the effect you are looking for would come from removing the
COMPILER* lines as well.
This doesn't really square up with the above comment about TLS though
because ONLY_FOR_ARCHS lists !base-clang arches. juanfra, do you know
what's going on here?
> Index: multimedia/mpv/Makefile
> ===================================================================
> RCS file: /cvs/ports/multimedia/mpv/Makefile,v
> retrieving revision 1.38
> diff -u -p -r1.38 Makefile
> --- multimedia/mpv/Makefile 23 Oct 2017 17:10:52 -0000 1.38
> +++ multimedia/mpv/Makefile 20 Jan 2018 00:42:26 -0000
> @@ -1,7 +1,7 @@
> # $OpenBSD: Makefile,v 1.38 2017/10/23 17:10:52 sthen Exp $
>
> # archs with atomic ops
> -ONLY_FOR_ARCHS = aarch64 alpha amd64 i386 mips64 mips64el powerpc sparc64
> +ONLY_FOR_ARCHS = aarch64 alpha amd64 arm i386 mips64 mips64el powerpc sparc64
> BROKEN-powerpc = atomics detection fails
>
> COMMENT = movie player based on MPlayer/mplayer2
This is probably better written as
NOT_FOR_ARCHS = hppa landisk luna88k m88k
(The current line is missing aarch64).
> Index: x11/qt4/Makefile
> ===================================================================
> RCS file: /cvs/ports/x11/qt4/Makefile,v
> retrieving revision 1.150
> diff -u -p -r1.150 Makefile
> --- x11/qt4/Makefile 4 Jan 2018 09:34:24 -0000 1.150
> +++ x11/qt4/Makefile 20 Jan 2018 00:56:07 -0000
> @@ -150,12 +150,6 @@ CONFIGURE_ARGS +=-release
>
> .include <bsd.port.arch.mk>
>
> -MODULES = gcc4
> -
> -# for __sync_add_and_fetch_4, __sync_sub_and_fetch_4
> -MODGCC4_ARCHS = arm
> -MODGCC4_LANGS = c++
> -
> LIB_DEPENDS =
> WANTLIB =
> RUN_DEPENDS =
I wondered about the ".include <bsd.port.arch.mk>" here. Turns out it's
to support "no_examples" builds which were removed with Makefile r1.122
so that could be removed as well, but that's unrelated to the
MODULES=gcc4 things.
> Other BROKEN markers are suspect as well
>
> devel/codeblocks/Makefile:BROKEN-arm= wxwidgets va_list c++ mangling requires gcc < 4.4
> devel/arm-none-eabi/gcc-linaro/Makefile:BROKEN-armv7= error during libgcc autoconf "checking for suffix of object files", probably similar to i386
> devel/reposurgeon/Makefile:BROKEN-arm= out of memory compiling cyreposurgeon.c
> games/crimson/Makefile:BROKEN-arm= mktileset buggy, loops at high CPU use
> games/stone-soup/Makefile:BROKEN-arm= tilegen.elf loops burning cpu
> games/fifengine/Makefile:BROKEN-arm = out of memory when compiling fifePYTHON_wrap.cxx
> lang/seed7/Makefile:BROKEN-arm = gmake: *** [makefile:279: ../bin/make7] Bus error (core dumped)
> security/john-jumbo/Makefile:BROKEN-arm = uaf_encode_plug.c:61: error: stray '$' in program
Unless phessler objects I think it would probably make sense to try
removing these as well.
No comments:
Post a Comment