Re: NEW: net/frrouting

Attached is the updated port, fixing nits, adding the Python dependency, and
not mucking up /etc.

* Pierre Emeriaud <petrus.lt+openbsd@gmail.com> [2018-04-30 20:05]:
> 2018-04-30 20:43 GMT+02:00 Aaron A. Glenn <aag@bsd.network>:
>
> I had those issues with your port earlier today but only when using
> rcctl, not when launching the daemons manually.

Despite my best efforts, I've exhausted my knowledge in trying to fix this.

frr# ls -alhf /etc | grep frr
drwxr-x--- 2 _frr _frr 512B May 1 14:39 frr
frr# ls -alhf /etc/frr
total 48
drwxr-x--- 2 _frr _frr 512B May 1 14:39 .
drwxr-xr-x 23 root wheel 1.5K May 1 23:13 ..
-rw-r----- 1 _frr _frr 622B May 1 14:39 bgpd.conf
-rw-r----- 1 _frr _frr 186B May 1 14:39 eigrpd.conf
-rw-r----- 1 _frr _frr 789B May 1 14:39 isisd.conf
-rw-r----- 1 _frr _frr 650B May 1 14:39 ldpd.conf
-rw-r----- 1 _frr _frr 1.1K May 1 14:39 ospf6d.conf
-rw-r----- 1 _frr _frr 182B May 1 14:39 ospfd.conf
-rw-r----- 1 _frr _frr 343B May 1 14:39 ripd.conf
-rw-r----- 1 _frr _frr 325B May 1 14:39 ripngd.conf
-rw-r----- 1 _frr _frr 128B May 1 14:39 vtysh.conf
-rw-r----- 1 _frr _frr 305B May 1 14:39 zebra.conf
frr# rcctl get frr_bgpd
frr_bgpd_class=daemon
frr_bgpd_flags=
frr_bgpd_rtable=0
frr_bgpd_timeout=30
frr_bgpd_user=root
frr# rcctl get frr_isisd
frr_isisd_class=daemon
frr_isisd_flags=NO
frr_isisd_rtable=0
frr_isisd_timeout=30
frr_isisd_user=root
frr# rcctl -d start frr_isisd
doing _rc_parse_conf
doing _rc_quirks
frr_isisd_flags empty, using default ><
doing _rc_parse_conf /var/run/rc.d/frr_isisd
doing _rc_quirks
doing rc_check
frr_isisd
doing rc_start
doing _rc_wait start
doing rc_check
2018/05/01 23:25:59 errors: ISIS: Failure to chdir to /etc/frr/, errno: 13
doing _rc_rm_runfile
(failed)
frr# rcctl -d start frr_bgpd
doing _rc_parse_conf
doing _rc_quirks
frr_bgpd_flags empty, using default ><
doing _rc_parse_conf /var/run/rc.d/frr_bgpd
doing _rc_quirks
doing rc_check
frr_bgpd
doing rc_start
doing _rc_wait start
2018/05/01 23:26:00 doing rc_check
errors: BGP: Failure to chdir to /etc/frr/, errno: 13
doing _rc_rm_runfile
(failed)
frr# /usr/local/sbin/bgpd -f /etc/frr/bgpd.conf
2018/05/01 23:26:17 BGP: bgpd 4.0 starting: vty@2605, bgp@<all>:179
^C2018/05/01 23:26:27 BGP: Terminating on signal
frr# /usr/local/sbin/bgpd
2018/05/01 23:26:31 BGP: bgpd 4.0 starting: vty@2605, bgp@<all>:179
^C2018/05/01 23:26:41 BGP: Terminating on signal
frr#

In the code, the line is 2948 in lib/vty.h

static void vty_save_cwd(void)
{
char cwd[MAXPATHLEN];
char *c;

c = getcwd(cwd, MAXPATHLEN);

if (!c) {
/*
* At this point if these go wrong, more than likely
* the whole world is coming down around us
* Hence not worrying about it too much.
*/
if (!chdir(SYSCONFDIR)) {
zlog_err("Failure to chdir to %s, errno: %d",
SYSCONFDIR, errno);
exit(-1);
}
if (getcwd(cwd, MAXPATHLEN) == NULL) {
zlog_err("Failure to getcwd, errno: %d",
errno);
exit(-1);
}
}

vty_cwd = XMALLOC(MTYPE_TMP, strlen(cwd) + 1);
strcpy(vty_cwd, cwd);
}