Re: Update oniguruma

On 2018/05/26 08:04, Martijn van Duren wrote:
> Here's an update for oniguruma. I found that it breaks some of the old
> APIs, but I couldn't find anything in ports that depends on it.

libslang still seems happy, a couple of tweaks inline below:

> OK?
>
> martijn@
>
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/textproc/oniguruma/Makefile,v
> retrieving revision 1.7
> diff -u -p -r1.7 Makefile
> --- Makefile 16 Jul 2015 23:21:48 -0000 1.7
> +++ Makefile 26 May 2018 06:00:50 -0000
> @@ -2,20 +2,22 @@
>
> COMMENT= regular expressions library
>
> -V= 5.9.6
> -DISTNAME= onig-$V
> -SHARED_LIBS= onig 2.1
> -PKGNAME= oniguruma-$V
> +V= 6.8.2
> +DISTFILES= onig-${V}.tar.gz
> CATEGORIES= textproc
> +PKGNAME= oniguruma-${V}

Please keep DISTNAME/PKGNAME as they were and remove the added WRKDIST.

>
> -HOMEPAGE= http://www.geocities.jp/kosako3/oniguruma/
> +
> +SHARED_LIBS= onig 5.0

3.0

> +HOMEPAGE= https://github.com/kkos/oniguruma/
>
> # BSD
> PERMIT_PACKAGE_CDROM= Yes
>
> -MASTER_SITES= ${HOMEPAGE}/archive/
> +MASTER_SITES= ${HOMEPAGE}/releases/download/v${V}/

prefer this as a full URL i.e.
https://github.com/kkos/oniguruma/releases/download/v${V}/

>
> CONFIGURE_STYLE=gnu
> +WRKDIST= ${WRKDIR}/onig-${V}
>
> USE_GMAKE= Yes

gmake isn't needed.

OK with those changes, please mention the CVEs in the commit log.