Hi,
Since the update of Qt to 5.9.6 I was experiencing a bug. Specifically,
certain GUI widgets of the mail/trojita port did not take all the space
available, which resulted in quite some screen estate being wasted.
I am not aware of any other ports that are affected.
Today I noticed that a commit appeared on the 5.9 branch of qtbase which
fixes the problem. Apparently the bug was known for some time already.
The diff below backports the commit.
The bug report: https://bugreports.qt.io/browse/QTBUG-68939
The commit:
https://code.qt.io/cgit/qt/qtbase.git/commit/?id=eaa2e164b0559b37dbcd060cd31e110d2775ffd6
Would you mind reviewing and committing the patch?
Thanks,
Caspar Schutijser
Index: Makefile
===================================================================
RCS file: /cvs/ports/x11/qt5/qtbase/Makefile,v
retrieving revision 1.19
diff -u -p -r1.19 Makefile
--- Makefile 11 Mar 2018 08:20:22 -0000 1.19
+++ Makefile 16 Aug 2018 18:06:29 -0000
@@ -17,6 +17,8 @@ PKGNAME-psql = qt5-postgresql-${VERSION
PKGNAME-sqlite2 = qt5-sqlite2-${VERSION}
PKGNAME-tds = qt5-tds-${VERSION}
+REVISION-main = 0
+
PKG_ARCH-global = *
PKG_ARCH-examples = *
Index: patches/patch-src_widgets_widgets_qdockarealayout_cpp
===================================================================
RCS file: patches/patch-src_widgets_widgets_qdockarealayout_cpp
diff -N patches/patch-src_widgets_widgets_qdockarealayout_cpp
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ patches/patch-src_widgets_widgets_qdockarealayout_cpp 16 Aug 2018 18:06:29 -0000
@@ -0,0 +1,92 @@
+$OpenBSD$
+
+Backport
+https://code.qt.io/cgit/qt/qtbase.git/commit/?id=eaa2e164b0559b37dbcd060cd31e110d2775ffd6
+which fixes https://bugreports.qt.io/browse/QTBUG-68939
+
+Index: src/widgets/widgets/qdockarealayout.cpp
+--- src/widgets/widgets/qdockarealayout.cpp.orig
++++ src/widgets/widgets/qdockarealayout.cpp
+@@ -226,7 +226,7 @@ static quintptr tabId(const QDockAreaLayoutItem &item)
+ static const int zero = 0;
+
+ QDockAreaLayoutInfo::QDockAreaLayoutInfo()
+- : restoredSizeHint(0,0), sep(&zero), dockPos(QInternal::LeftDock), o(Qt::Horizontal), mainWindow(0)
++ : sep(&zero), dockPos(QInternal::LeftDock), o(Qt::Horizontal), mainWindow(0)
+ #if QT_CONFIG(tabbar)
+ , tabbed(false), tabBar(0), tabBarShape(QTabBar::RoundedSouth)
+
No comments:
Post a Comment