Wednesday, August 08, 2018

Re: add audio/timidity to games/prboom

On 2018/08/08 10:46, Solene Rapenne wrote:
> while testing prboom I found this message in the console output:
>
> Couldn't load MIDI from /tmp/prboom-music-IaDpVf: /etc/timidity.cfg: No such file or directory
>
> and in fact the game had no music, only sounds.
>
> The following patch add audio/timidity as a LIB_DEPENDS, once
> timidity is installed, prboom plays the music as expected.
>
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/games/prboom/Makefile,v
> retrieving revision 1.25
> diff -u -p -r1.25 Makefile
> --- Makefile 28 Sep 2017 23:12:48 -0000 1.25
> +++ Makefile 8 Aug 2018 08:45:51 -0000
> @@ -15,7 +15,8 @@ PERMIT_PACKAGE_CDROM= Yes
>
> WANTLIB = SDL c m pthread z GL GLU SDL_mixer>=3 SDL_net>=1 png>=4
>
> -LIB_DEPENDS = devel/sdl-mixer \
> +LIB_DEPENDS = audio/timidity \
> + devel/sdl-mixer \
> devel/sdl-net \
> graphics/png
>

That change is a noop, LIB_DEPENDS is stripped unless there is a
matching WANTLIB - see "LIB_DEPENDS <spec> not needed for <FULLPKGPATH>"
in DIAGNOSTICS in bsd.port.mk(5).

(If it wasn't a noop, it would need a REVISION bump as well).

No comments:

Post a Comment