Saturday, August 04, 2018

Re: [NEW] devel/libdivecomputer-subsurface

Hi Kristaps,

Kristaps Dzonsons BSD.LV wrote on Fri, Aug 03, 2018 at 01:34:58AM +0200:

> Enclosed are both subsurface.tgz

See my previous mail, which also contained more changes
and also asked for OKs.

> and libdivecomputer.tgz, which have the noted change.
> (Both are now in misc.) Both tested on amd64.
> (I do have a utility that uses libdivecomputer and will submit it soon.)

Regarding libdivecomputer, i'm looking for OKs and for confirmation
from kristaps@ for the attached version:

* License check successfully redone.
* Restore the AES removal patches; don't be illegal...
* WANTLIB += m according to lib-depends-check and ldd(1).
* Move USE_GMAKE up according to Makefile.template ordering.
* CONFIGURE_ENV = ac_cv_prog_DOXYGEN=, or it will pick it up.
* Do not build HTML documentation, we install mdoc(7) files.
* NO_TEST is not needed; there is an empty test infrastructure.
* Fix the test for compiler flags in ./configure: for -Wrestrict,
clang warns, but exits 0 anyway, resulting in the flag being
used, which causes lots of noise in the build log.
* With these changes, configure, build, and fake logs look sane.

OK?
Ingo

No comments:

Post a Comment