On 8/12/18 4:28 PM, Klemens Nanni wrote:
> Port itself looks good, i cannot test the game, thouugh.
>
> The second part of DESCR explaining how to set up the game rather
> belongs into README imho. Thoughts on this?
>
How about this version, which uses a 1-line patch to the Makefile to get
rid of that arch dance you're doing there. I think it's a bit more
elegant and obvious this way.
I also don't own the game, so also can't test; but yes kn@ is right that
we tend to put instructions in a pkg/README, though I wouldn't object to
have the information in both places.
What I do object to is that there's no mention of the fact that Quake
itself is still software that you must purchase in order to use ezquake.
See games/julius for example language to be put into this port.
~Brian
No comments:
Post a Comment