Re: [NEW] games/ezquake

On Wed, Aug 15, 2018 at 10:53:23AM -0400, Brian Callahan wrote:
>
> On 08/15/18 09:00, Tom Murphy wrote:
> > On Tue, Aug 14, 2018 at 07:15:42PM -0400, Brian Callahan wrote:
> > > On 08/14/18 03:29, Tom Murphy wrote:
> > > > On Sun, Aug 12, 2018 at 04:47:54PM -0400, Brian Callahan wrote:
> > > > > On 8/12/18 4:28 PM, Klemens Nanni wrote:
> > > > > > Port itself looks good, i cannot test the game, thouugh.
> > > > > >
> > > > > > The second part of DESCR explaining how to set up the game rather
> > > > > > belongs into README imho. Thoughts on this?
> > > > > >
> > > > > How about this version, which uses a 1-line patch to the Makefile to get rid
> > > > > of that arch dance you're doing there. I think it's a bit more elegant and
> > > > > obvious this way.
> > > > >
> > > > > I also don't own the game, so also can't test; but yes kn@ is right that we
> > > > > tend to put instructions in a pkg/README, though I wouldn't object to have
> > > > > the information in both places.
> > > > >
> > > > > What I do object to is that there's no mention of the fact that Quake itself
> > > > > is still software that you must purchase in order to use ezquake. See
> > > > > games/julius for example language to be put into this port.
> > > > >
> > > > > ~Brian
> > > > >
> > > > Hi Brian,
> > > >
> > > > Thanks for this! That does fix the arch dance, and I moved the instructions
> > > > from pkg/DESCR into pkg/README.
> > > >
> > > > Attached is the port with the changes requested.
> > > >
> > > > Is this OK?
> > > >
> > > > Thanks,
> > > > Tom
> > > >
> > > >
> > > Attached back is a tarball with some tweaks. I think this version is ok.
> > >
> > > ~Brian
> > >
> > Hi Brian,
> >
> > Sorry but I'm not sure why you removed audio/speexdsp from the Makefile.
> > The game docs state this is a required library. (See:
> > https://ezquake.github.io/docs/guides/voice-support.html)
> >
> > Even the ezquake binary I built links to this library (in the ldd output).
> >
> > -Tom
> >
>
> audio/speex already has audio/speexdsp linked into it (see the audio/speex
> Makefile and double-check with make port-lib-depends-check in
> games/ezquake).
>
> ~Brian

OK I'm happy with that (and the formatting changes make sense).
Feel free to commit if allowed/approved, thanks!

-Tom