Re: [NEW] games/ezquake

On 08/15/18 16:44, Adam Wolk wrote:
> On Wed, Aug 15, 2018 at 05:51:33PM +0100, Tom Murphy wrote:
>> On Wed, Aug 15, 2018 at 10:53:23AM -0400, Brian Callahan wrote:
>>>>>>> games/julius for example language to be put into this port.
>>>>>>>
>>>>>>> ~Brian
>>>>>>>
>>>>>> Hi Brian,
>>>>>>
>>>>>> Thanks for this! That does fix the arch dance, and I moved the instructions
>>>>>> from pkg/DESCR into pkg/README.
>>>>>>
>>>>>> Attached is the port with the changes requested.
>>>>>>
>>>>>> Is this OK?
>>>>>>
>>>>>> Thanks,
>>>>>> Tom
>>>>>>
>>>>>>
>>>>> Attached back is a tarball with some tweaks. I think this version is ok.
>>>>>
>>>>> ~Brian
>>>>>
>>>> Hi Brian,
>>>>
>>>> Sorry but I'm not sure why you removed audio/speexdsp from the Makefile.
>>>> The game docs state this is a required library. (See:
>>>> https://ezquake.github.io/docs/guides/voice-support.html)
>>>>
>>>> Even the ezquake binary I built links to this library (in the ldd output).
>>>>
>>>> -Tom
>>>>
>>> audio/speex already has audio/speexdsp linked into it (see the audio/speex
>>> Makefile and double-check with make port-lib-depends-check in
>>> games/ezquake).
>>>
>>> ~Brian
>> OK I'm happy with that (and the formatting changes make sense).
>> Feel free to commit if allowed/approved, thanks!
>>
>> -Tom
>>
> This is OK awolk@, go ahead if you want to import it Brian.
>
> Regards,
> Adam

Committed, thanks.

~Brian