Hiltjo Posthuma <hiltjo@codemadness.org> wrote:
> On Wed, Aug 15, 2018 at 06:10:51PM +0100, Stuart Henderson wrote:
> > On 2018/08/14 17:45, Hiltjo Posthuma wrote:
> > > +Use base pcre library.
> >
> > This is a bit confusing - there's no pcre library in base (it's in
> > packages), and the second part of the patch is something to do with
> > restoring LDFLAGS. I'd either skip the comment, or reword ("don't
> > use bundled pcre" perhaps?) and explain both parts.
> >
> > > +Use the proper hmrc man page category number 5 for file formats.
> >
> > It doesn't hurt, but this seems a bit superfluous, the patches
> > speak for themselves.
> >
>
> Hi,
>
> Thanks for the feedback. I also made a few other mistakes:
>
> Changes vs previous patch:
>
> - Remove superfluous comments.
> - Don't update the patch which don't have line (offset) changes.
> - Add patch back again for doc/hypermail.html, line offset changed.
>
>
still ok solene@ with last patches
I tested it quickly with cat /var/mail/solene | hypermail -i and it produced
something usable.
No comments:
Post a Comment