Re: update sysutils/ranger to 1.9.2

On 2018/10/02 01:05, Klemens Nanni wrote:
> Version 1.9.2 is out, fixing some crashes due to python 3.6/3.7.
> Introducing native Kitty image previews and a dired-filter inspired
> filter stack.
> https://ranger.github.io/changelog.html
>
> Besides this, I replaced post-install with a setup.py patch and adjusted
> to test suite changes:
>
> - adjust shebang
> - requires gmake
> - pass HOME for write tests
> - pass TERM for terminfo tests
> - specify pylint version requirement as per Pipfile
> - needs devel/astroid>=1.5.0 but our tree is still as 1.4.9
>
> Due to the last point our test target does no finish but since it's a
> minor issue and other tests pass, I'd like to handle this separately
> once astroid has been updated.
>
> Continues to work for me on amd64.
>
> Feedback? OK?

update looks sane, a few comments in-line:

> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/sysutils/ranger/Makefile,v
> retrieving revision 1.7
> diff -u -p -r1.7 Makefile
> --- Makefile 22 Feb 2018 16:51:50 -0000 1.7
> +++ Makefile 1 Oct 2018 22:52:47 -0000
> @@ -2,10 +2,11 @@
>
> COMMENT = minimalistic console file manager
>
> -MODPY_EGG_VERSION = 1.9.1
> +MODPY_EGG_VERSION = 1.9.2
> DISTNAME = ranger-${MODPY_EGG_VERSION}
>
> -CATEGORIES = sysutils misc
> +CATEGORIES = sysutils \
> + misc

doesn't really matter but this isn't usually split onto multiple lines

<snip>
> # libarchive (bsdtar) used as an alternative to atool
> RUN_DEPENDS = archivers/libarchive \
> shells/bash \
> textproc/py-chardet${MODPY_FLAVOR}
<snip>
> +@tag update-desktop-database

If you want to use the @tag you need a dependency. iirc this was deliberately
left out to reduce dependencies before (though desktop-file-utils isn't too
bad, it's much lighter than update-icon-cache).