Re: UPDATE: Varnish-6.1.0

On 2018/10/05 11:24, Klemens Nanni wrote:
> On Thu, Oct 04, 2018 at 11:06:41PM +0100, Stuart Henderson wrote:
> > On 2018/10/04 23:30, Klemens Nanni wrote:
> > > OK with:
> > >
> > > > @@ -30,7 +30,8 @@ MODPY_ADJ_FILES = lib/libvcc/{vsc,vmod}t
> > > > BUILD_DEPENDS = ${MODGNU_AUTOCONF_DEPENDS} \
> > > > ${MODGNU_AUTOMAKE_DEPENDS} \
> > > > devel/libtool \
> > > > - textproc/py-docutils${MODPY_FLAVOR}
> > > > + textproc/py-docutils${MODPY_FLAVOR} \
> > > > + textproc/py-sphinx
> > > sphinx is flavored as well.
> > >
> >
> > It calls sphinx-build (not sphinx-build-3), so it specifically wants the py-sphinx
> > and not py3-sphinx.
> Hm, I think then it should me mentioned somewhere or fixed right away
> by using flavors and symlinking the version or so:
>
> pre-build:
> ln -sf ${LOCALBASE}/bin/sphinx-build${MODPY_BIN_SUFFIX} \
> ${WRKDIR}/bin/sphinx-build
>

varnish just uses sphinx and docutils (and a couple of its own scripts)
as utilities during build, it doesn't care about the python version
for those, I think all the MODPY_FLAVOR handling in a port which doesn't
even use python at runtime is a bit unnecessary.

Generally there seems no reason to be able to choose between "sphinx-foo
run with py2" and "sphinx-foo run with py3" so I'd actually prefer
splitting the tools from the modules in things like py-sphinx and
py-docutils, have them just use a current python version, and skip
renaming the installed scripts (as there will then be no conflict).
But obviously that's not for this point in the release cycle.