On 2018/11/29 17:36, George Koehler wrote:
> On Thu, 29 Nov 2018 09:38:31 +0100
> Olivier Taïbi <oli@olitb.net> wrote:
>
> > 2) remove the check
> > if (job_pid == getpgid(job_pid))
> > from vim's mch_signal_job() in src/os_unix.c so that the whole group
> > always gets a signal.
>
> Thank you for finding the failing getpgid(). I suggest to remove the
> check, like in the below diff. The process group id should equal the
> process id after vim called setsid(2) or setpgid(2). I had helped to
> remove a similar getpgid() call from meson:
> https://github.com/mesonbuild/meson/commit/64906b0
Thanks for digging into this. I definitely would prefer to handle this
via upstream rather than as a patch in ports..
No comments:
Post a Comment