On Fri, Oct 19 2018, Solene Rapenne <solene@perso.pw> wrote:
> Tom Murphy <openbsd@pertho.net> wrote:
>> On Thu, Oct 04, 2018 at 12:11:01PM +0200, Solene Rapenne wrote:
>> > Small introduction for people reading ports@.
>> >
>> > mvdsv is a quake world game server. It has some features like allowing to
>> > record games from every player point of view. That can be played again in a
>> > quake client like ezquake.
>> >
>> > ok solene@
>>
>> Thanks Solene and Stuart for their help! Attached is a new tarball using
>> GH_TAGNAME and the correct DISTFILES settings.
>>
>> -Tom
>
> up
>
> looks fine to me
The build system is not very portable. The configure script hardcodes
a bunch of arch-dependent logic which breaks on eg. sparc64:
../../src/pr_exec.c:1: error: -m32 is not supported by this configuration
Also, Makefile.BSD contains:
--8<--
. if ${MACHINE_ARCH} == "i386" && !defined(WITHOUT_X86_ASM)
USE_ASM=-Did386
DO_CFLAGS += ${USE_ASM}
. endif
-->8--
It would be good to check that the port builds on i386 with assembly
enabled. Or you could wait for bulk build reports. ;)
Using devel/meson could be a nicer alternative to Makefile.BSD, which
looks a bit outdated (no curl support for example). Else, we could pass
arguments to the CONFIGURE_SCRIPT to fix its behavior.
Another concern: I think this has already been pointed out by fcambus@,
qwprogs.dat should have a versioned file name, should it be updated some
day.
Here's an updated tarball, Makefile diff below to ease review. With
those changes, ok jca@ to import
No comments:
Post a Comment