Re: [REVISION] x11/lxqt/build-tools and x11/lxqt/libqtxdg

Index: x11/lxqt/build-tools/Makefile
===================================================================
RCS file: /cvs/ports/x11/lxqt/build-tools/Makefile,v
retrieving revision 1.1.1.1
diff -u -p -u -r1.1.1.1 Makefile
--- x11/lxqt/build-tools/Makefile 14 Sep 2018 15:17:26 -0000 1.1.1.1
+++ x11/lxqt/build-tools/Makefile 14 Nov 2018 19:53:22 -0000
@@ -3,6 +3,7 @@
COMMENT = various packaging tools and scripts for LXQt applications

VERSION = 0.5.0
+REVISION = 0

NAME = lxqt-build-tools
DISTNAME = ${NAME}-${VERSION}
Index: x11/lxqt/build-tools/patches/patch-cmake_modules_LXQtCompilerSettings_cmake
===================================================================
RCS file: /cvs/ports/x11/lxqt/build-tools/patches/patch-cmake_modules_LXQtCompilerSettings_cmake,v
retrieving revision 1.1.1.1
diff -u -p -u -r1.1.1.1 patch-cmake_modules_LXQtCompilerSettings_cmake
--- x11/lxqt/build-tools/patches/patch-cmake_modules_LXQtCompilerSettings_cmake 14 Sep 2018 15:17:26 -0000 1.1.1.1
+++ x11/lxqt/build-tools/patches/patch-cmake_modules_LXQtCompilerSettings_cmake 14 Nov 2018 19:53:22 -0000
@@ -20,3 +20,13 @@ Index: cmake/modules/LXQtCompilerSetting
)
set(CMAKE_EXE_LINKER_FLAGS
"${SYMBOLIC_FLAGS} ${CMAKE_EXE_LINKER_FLAGS}"
+@@ -153,7 +153,8 @@ endif()
+ # Turn on more aggrassive optimizations not supported by CMake
+ # References: https://wiki.qt.io/Performance_Tip_Startup_Time
+ #-----------------------------------------------------------------------------
+-if (CMAKE_COMPILER_IS_GNUCXX OR LXQT_COMPILER_IS_CLANGCXX)
++if ((CMAKE_COMPILER_IS_GNUCXX OR LXQT_COMPILER_IS_CLANGCXX) AND
++ NOT (CMAKE_SYSTEM_NAME STREQUAL OpenBSD))
+ # -flto: use link-time optimizations to generate more efficient code
+ if (CMAKE_COMPILER_IS_GNUCXX)
+ set(LTO_FLAGS "-flto -fuse-linker-plugin")
Index: x11/lxqt/libqtxdg/Makefile
===================================================================
RCS file: /cvs/ports/x11/lxqt/libqtxdg/Makefile,v
retrieving revision 1.1.1.1
diff -u -p -u -r1.1.1.1 Makefile
--- x11/lxqt/libqtxdg/Makefile 14 Sep 2018 15:17:26 -0000 1.1.1.1
+++ x11/lxqt/libqtxdg/Makefile 14 Nov 2018 19:53:23 -0000
@@ -3,6 +3,7 @@
COMMENT = qt implementation of freedesktop.org xdg specs

VERSION = 3.2.0
+REVISION = 0

NAME = libqtxdg
DISTNAME = ${NAME}-${VERSION}
Index: x11/lxqt/libqtxdg/patches/patch-cmake_compiler_settings_cmake
===================================================================
RCS file: /cvs/ports/x11/lxqt/libqtxdg/patches/patch-cmake_compiler_settings_cmake,v
retrieving revision 1.1.1.1
diff -u -p -u -r1.1.1.1 patch-cmake_compiler_settings_cmake
--- x11/lxqt/libqtxdg/patches/patch-cmake_compiler_settings_cmake 14 Sep 2018 15:17:26 -0000 1.1.1.1
+++ x11/lxqt/libqtxdg/patches/patch-cmake_compiler_settings_cmake 14 Nov 2018 19:53:23 -0000
@@ -20,3 +20,13 @@ Index: cmake/compiler_settings.cmake
)
set(CMAKE_EXE_LINKER_FLAGS
"${SYMBOLIC_FLAGS} ${CMAKE_EXE_LINKER_FLAGS}"
+@@ -147,7 +147,8 @@ endif()
+ # Turn on more aggrassive optimizations not supported by CMake
+ # References: https://wiki.qt.io/Performance_Tip_Startup_Time
+ #-----------------------------------------------------------------------------
+-if (CMAKE_COMPILER_IS_GNUCXX OR QTXDG_COMPILER_IS_CLANGCXX)
++if ((CMAKE_COMPILER_IS_GNUCXX OR LXQT_COMPILER_IS_CLANGCXX) AND
++ NOT (CMAKE_SYSTEM_NAME STREQUAL OpenBSD))
+ # -flto: use link-time optimizations to generate more efficient code
+ if (CMAKE_COMPILER_IS_GNUCXX)
+ set(LTO_FLAGS "-flto -fuse-linker-plugin")
Small ping for a small change.

On Thu, Nov 15, 2018 at 6:35 AM Elias M. Mariani <marianielias@gmail.com> wrote:
>
> From George Koehler:
> https://marc.info/?l=openbsd-ports&m=154118440613320
> "The build system tries to use link-time optimization (-flto
> -fuse-linker-plugin). This fails because -fuse-linker-plugin "is
> available in gold or in GNU ld 2.21 or newer" (says man egcc), but
> OpenBSD has GNU ld 2.17.
>
> x11/lxqt/build-tools enables LTO for gcc, so the failure would happen
> on ports-gcc arches like powerpc. Most packages outside LXQt don't
> enable LTO, so I disabled LTO by modifying x11/lxqt/build-tools."
> Thanks to George Koehler for the solution.
>
> The same applies to x11/lxqt/libqtxdg.
>
> Thanks landry@ for the bulk with the failure report.
>
> This should fix the build on non-clang archs.
>
> Cheers.
> Elias.