On Wed, Jan 30 2019, Sebastien Marie <semarie@online.fr> wrote:
> Hi,
>
> The following diff on devel/llvm unbreak www/mozilla-firefox build.
>
> firefox used rustc with `-C lto' option for some part of its build, and
> this code path expose a bug in llvm-7.
>
> with current tree, rustc SIGSEG when building gkrust compoment of
> firefox, due to this bug.
>
> on rust side, it is documented on https://github.com/rust-lang/rust/issues/57762
>
> I followed the recommandation to backport some llvm patches to correct
> the underline problem:
>
> - https://github.com/llvm-mirror/llvm/commit/da1fb72bb305d6bc1f3899d541414146934bf80f
> - https://github.com/llvm-mirror/llvm/commit/cc1f2a595ead516812a6c50398f0f3480ebe031f
>
> Technically only a part of the commits is necessary (the one on
> lib/Bitcode/Reader/MetadataLoader.cpp), as other parts are for tests.
>
> The following diff backport the two llvm patches in your devel/llvm and
> bump lang/rust to ensure updated statically linked libraries are taken.
>
> For reference, the underline llvm problem is related to DWARF variant
> support in Enums (if I correctly understand the bug report in
> rustc). The backport of patches could be considered for base too I
> think.
>
> Comments or ok ?
As said earlier, makes sense. ok jca@, please go ahead.
--
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
No comments:
Post a Comment