On Sun, 6 Jan 2019 18:12:35 -0700
Andrew Hewus Fresh wrote:
> On Mon, Jan 07, 2019 at 01:48:47AM +0100, Charlene Wendling wrote:
> > On Sun, 6 Jan 2019 16:55:54 -0700
> > Andrew Hewus Fresh wrote:
> >
> > > On Sat, Dec 29, 2018 at 11:47:43AM +0100, Charlene Wendling wrote:
> > > > Hi ports,
> > > >
> > > > Here is an update for Data::FormValidator that fixes the build
> > > > with our future Perl 5.28, and unbreaks tests with our current
> > > > Perl.
> > >
> > > The documentation in the README.pod is the same as as what is in
> > > Data/Validator.pm and so I think we should avoid installing it as
> > > Data::README is not really part of this namespace and confuses
> > > things.
> > >
> > > Avoid installing that and this is OK with me.
> > >
> >
> > [snip]
> >
> > Agreed.
> >
> > This is what i can do to the best of my knowledge.
> >
> > It builds and installs properly, and 'make test' Pod coverage still
> > passes.
>
> I would rather not install Data::Readme.3p either as it is the same
> content as Data::FormValidator.3p other than the name and the latter
> has a much more useful name.
>
> I saw that one of the other recent updates had avoided installing a
> README, but I think your way of just deleting it after is probably
> better than the patch, unless someone feels like submitting the patch
> upstream.
>
> https://metacpan.org/diff/file?target=BDFOY/Test-File-1.43/&source=BDFOY%2FTest-File-1.42
That's great, and filling a RT is less annoying than a GitHub PR:
https://rt.cpan.org/Public/Bug/Display.html?id=128187
Charlène.
Index: Makefile
===================================================================
RCS file: /cvs/ports/devel/p5-Data-FormValidator/Makefile,v
retrieving revision 1.14
diff -u -p -u -p -r1.14 Makefile
--- Makefile 20 Mar 2016 19:56:17 -0000 1.14
+++ Makefile 7 Jan 2019 02:58:16 -0000
@@ -1,25 +1,25 @@
# $OpenBSD: Makefile,v 1.14 2016/03/20 19:56:17 naddy Exp $
-COMMENT= validate user input from a constraint object
+COMMENT= validate user input from a constraint object
MODULES= cpan
PKG_ARCH= *
-DISTNAME= Data-FormValidator-4.63
-REVISION= 1
-CATEGORIES= devel
+DISTNAME= Data-FormValidator-4.88
+CATEGORIES= devel
# perl
PERMIT_PACKAGE_CDROM= Yes
RUN_DEPENDS= graphics/p5-Image-Size \
devel/p5-Date-Calc \
- devel/p5-Perl6-Junction \
misc/p5-File-MMagic \
mail/p5-Email-Valid \
mail/p5-MIME-Types \
textproc/p5-Regexp-Common
-TEST_DEPENDS=www/p5-CGI-Simple
+TEST_DEPENDS= textproc/p5-Template \
+ www/p5-CGI \
+ www/p5-CGI-Simple
-CONFIGURE_STYLE=modbuild
+MAKE_ENV += TEST_POD=Yes
.include <bsd.port.mk>
Index: distinfo
===================================================================
RCS file: /cvs/ports/devel/p5-Data-FormValidator/distinfo,v
retrieving revision 1.6
diff -u -p -u -p -r1.6 distinfo
--- distinfo 18 Jan 2015 03:13:24 -0000 1.6
+++ distinfo 7 Jan 2019 02:58:16 -0000
@@ -1,2 +1,2 @@
-SHA256 (Data-FormValidator-4.63.tar.gz) = NfBmauuPSDZ7bQEUXO22u72RrPXnuL0JYFNsRAB7dJ4=
-SIZE (Data-FormValidator-4.63.tar.gz) = 96892
+SHA256 (Data-FormValidator-4.88.tar.gz) = waU5+RySy82KjYNZfsmnZD/NjM9alOFTgsN2UokXAGY=
+SIZE (Data-FormValidator-4.88.tar.gz) = 99850
Index: patches/patch-Makefile_PL
===================================================================
RCS file: patches/patch-Makefile_PL
diff -N patches/patch-Makefile_PL
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ patches/patch-Makefile_PL 7 Jan 2019 02:58:16 -0000
@@ -0,0 +1,30 @@
+$OpenBSD$
+- Prevent the installation of README.Pod in an inappropriate place.
+- Don't install Data::Readme.3p, the content is similar to
+ Data::FormValidator.3p.
+Taken from:
+https://metacpan.org/source/BDFOY/Test-File-1.43//Makefile.PL
+Upstream bug report:
+https://rt.cpan.org/Public/Bug/Display.html?id=128187
+Index: Makefile.PL
+--- Makefile.PL.orig
++++ Makefile.PL
+@@ -37,3 +37,18 @@ WriteMakefile(
+ : ()
+ ),
+ );
++
++
++BEGIN {
++ use ExtUtils::MM_Unix;
++ package ExtUtils::MM_Unix;
++
++ my $original = \&ExtUtils::MM_Unix::init_dirscan;
++ no warnings 'redefine';
++
++ *init_dirscan = sub {
++ &$original;
++ delete $_[0]{PM}{'README.pod'};
++ $_[0];
++ };
++}
> l8rZ,
> --
> andrew - http://afresh1.com
>
> Hey! It compiles! Ship it!
>
No comments:
Post a Comment