Friday, January 04, 2019

Re: WIP: mail/postsrsd

On 7/27/18 12:09 PM, Stuart Henderson wrote:
> On 2018/07/27 10:15, Giovanni Bechis wrote:
>> Hi,
>> attached a port of postsrsd, an srs forwarding daemon for postfix.
>> A couple of doubts:
>> - It uses a secret file created at build time with "dd if=/dev/urandom bs=18 count=1 | /usr/bin/openssl base64 -e",
>> should we add a README on how to create it ?
>
> If it needs something that isn't clear from the upstream documentation,
> then adding it to a pkg-readme makes sense. (Not quite sure why they use
> dd | openssl rather than just openssl rand -base64 18 though!)
>
>> - the Linux startup script uses something like that:
>> -------------------------------------------------------------------
>> SRS_DOMAIN=`postconf -h mydomain || true`
>> daemon $DAEMON -d "$SRS_DOMAIN" ....
>> -------------------------------------------------------------------
>>
>> Does it make sense to write a similar rc script or is it better to let the user configure it by hand and add it to rc.local ?
>
> That seems like too much magic to me, setting postsrsd_flags in rc.conf.local
> by hand seems a better idea. That's something that would definitely fit for
> a pkg-readme.
>
> The rc script is missing from your tar.
>

new diff after a lot of time.
comments ? ok ?
Cheers
Giovanni

No comments:

Post a Comment