Re: WIP: net/libsignal-protocol-c

On 2019/03/07 13:55, Stefan Sperling wrote:
> On Thu, Mar 07, 2019 at 12:34:35AM -0700, Anthony J. Bentley wrote:
> > On Sun, Feb 17, 2019 at 2:57 PM Anthony J. Bentley <anthony@anjbe.name> wrote:
> > >
> > > Alex Holst writes:
> > > > Hi,
> > > >
> > > > Thanks for your input. It should all be adopted into this port except
> > > > for the 'test' target which I couldn't get working otherwise.
> > >
> > > No need for a do-test, just use:
> > >
> > > CONFIGURE_ARGS = -DBUILD_TESTING=ON
> >
> > Here's a port with that change, some minor whitespace changes, and a
> > tweaked DESCR.
> >
> > Is this ready to go in?
>
> Some files have the executable bit set, please clear them.
>
> It seems something is wrong with build dependencies.
> After 'make prepare' which installed cmake and ninja packages,
> I tried to run 'make package' and it failed:

Setting -DBUILD_TESTING adds check as a build requirement.

Is there a reason not to build the shared lib?

diff --git Makefile Makefile
index b325797..e1fb826 100644
--- Makefile
+++ Makefile
@@ -6,21 +6,24 @@ GH_ACCOUNT = signalapp
GH_PROJECT = libsignal-protocol-c
GH_TAGNAME = v2.3.2

+SHARED_LIBS += signal-protocol-c 0.0 # 2.3
+
CATEGORIES = net
HOMEPAGE = https://signal.org/

MAINTAINER = Alex Holst <a@mongers.org>

-# GPL 3
+# GPLv3 only
PERMIT_PACKAGE_CDROM = Yes

-WANTLIB += c pthread
+WANTLIB += m

MODULES = devel/cmake
RUN_DEPENDS = devel/protobuf-c
-TEST_DEPENDS = devel/check
+BUILD_DEPENDS = devel/check

-CONFIGURE_ARGS = -DBUILD_TESTING=ON
+CONFIGURE_ARGS = -DBUILD_TESTING=ON \
+ -DBUILD_SHARED_LIBS=ON

SUBST_VARS += VARBASE

diff --git pkg/PLIST pkg/PLIST
index 4b6a313..69b3695 100644
--- pkg/PLIST
+++ pkg/PLIST
@@ -19,5 +19,5 @@ include/signal/session_record.h
include/signal/session_state.h
include/signal/signal_protocol.h
include/signal/signal_protocol_types.h
-lib/libsignal-protocol-c.a
+@lib lib/libsignal-protocol-c.so.${LIBsignal-protocol-c_VERSION}
lib/pkgconfig/libsignal-protocol-c.pc