Re: [update] mpd 0.21.8

On Thu, May 02, 2019 at 02:48:54PM +0200, Charlene Wendling wrote:
> Hi,
>
> On Wed, 1 May 2019 21:44:22 +0200
> Landry Breuil <landry@openbsd.org> wrote:
>
> > On Sun, Apr 28, 2019 at 09:52:35AM +0200, Landry Breuil wrote:
> > > Hi,
> > >
> > > now that we have ffmpeg 4 & gcc 8, there should be no blocker
> > > anymore for updating mpd to the latest version of the 0.21 branch.
> > > All configure options changed since the switch to meson, i tried to
> > > keep them the same.
> > > might take maintainership, after all i've been using mpd for at
> > > least 12 years now...
> > >
> > > runtime tests welcome on gcc archs of course :)
> >
> > New diff, with correctly removed patches (hopefully). cvs sucks.
>
> There are undefined references errors on macppc because of --as-needed,
> it probably impacts all ld.bfd archs. Courtesy of Jeremie who met this
> on another port in the past, here is what you should add to the
> Makefile:
>
>
> --8<--
> # disable meson's default of using "-Wl,--as-needed" on ld.bfd arches;
> # build failures due to undefined references are often seen.
> .include <bsd.port.arch.mk>
> .if !${PROPERTIES:Mlld}
> CONFIGURE_ARGS += -Db_asneeded=false
> .endif
> -->8--

Cant we put this into meson.port.mk instead of cargoculting it in all
consumers ? or the fact that it depends on bsd.port.arch.mk prevents it
?

now i remember this hack and losing some time on it...