Saturday, June 01, 2019

Re: 回复: [New]www/p5-WWW-Form-UrlEncoded

Hi,

On Thu, 30 May 2019 10:14:48 -0700
Andrew Hewus Fresh wrote:

> On Thu, May 30, 2019 at 12:04:35AM +0000, wen heping wrote:
> > Hi,
> >
> > This is the revised patch which reviewed by cwen@.
> > Comments ?
>

For p5-WWW-Form-UrlEncoded i've let the old fix as-is. I could have put
instead the proposal i did to upstream [0], but i am not sure it will be
merged. I've added the XS module as a RUN_DEPENDS.

> This looks mostly OK, but the port for the XS module seemed pretty
> easy to make, so I'd like to see a RUN_DEPENDS on this so that Plack
> is hopefully slightly faster.
>
> Attached is mostly just a portgen(1) version of it.

- portgen(1) was not able to find the 'c' WANTLIB :|
- i reworded DESCR
- it builds on macppc

I'm attaching an all-in-one tarball. OK cwen@ on these 2 ports
if you're fine with them and willing to commit them.

Charlène.

[0] https://github.com/kazeburo/WWW-Form-UrlEncoded/pull/8

>
> l8rZ,
> --
> andrew - http://afresh1.com
>
> Full-time system administration is a delicate balance
> between proactiveness and laziness.
> -- jhorwitz from use.perl.org

No comments:

Post a Comment