Re: Makefile.template tweak

On Tue, July 2, 2019 13:55, Stuart Henderson wrote:
> On 2019/07/02 11:59, Antoine Jacoutot wrote:
>> On Tue, Jul 02, 2019 at 12:22:44PM +0300, Kirill Bychkov wrote:
>> > On Tue, July 2, 2019 11:55, Antoine Jacoutot wrote:
>> > > On Mon, Jul 01, 2019 at 10:00:29AM +0300, Kirill Bychkov wrote:
>> > >> Hi!
>> > >> The diff below moves COMPILER string template and its description
>> > >> to the position used in most of the ports.
>> > >> OK? Comments?
>> > >
>> > > While here, maybe worth add COMPILER_LANGS as well?
>> >
>> > Hi,
>> > Sorry, this change was commited. Anyway I'm not sure it is worth to add
>> > COMPILER_LANGS to the template because it's not so widely used as
>> > COMPILER. Currently I've found only 46 ports using it.
>
> I have to say, I don't like this location at all, it bunches COMPILER
> which needs extra comments in with the normal dependency lines making it
> more confusing to read. *Above* dep's is fine with me, but mixed in doesn't
> look good.
>
>> Yes and that's why I think it's important to add it.
>> Because people usually don't realize that it means c and c++ by default.
>> In the past, this added dependency on c++ compiler that wasn't needed in
>> some
>> ports.
>
> Yes I think that's a good idea.
>
> How about this?

Yeah, this explains both vars much better. ok kirby@

>
> Index: templates/Makefile.template
> ===================================================================
> RCS file: /cvs/ports/infrastructure/templates/Makefile.template,v
> retrieving revision 1.82
> diff -u -p -r1.82 Makefile.template
> --- templates/Makefile.template 1 Jul 2019 11:35:42 -0000 1.82
> +++ templates/Makefile.template 2 Jul 2019 10:54:37 -0000
> @@ -95,12 +95,14 @@ MASTER_SITES = ???
> #PATCHFILES = ???
> #PATCH_DIST_STRIP = -p0
>
> -# Dependencies
> -#
> -# For ports using C++, except in special cases you should use a compiler
> -# with the same standard library as used in other ports. Remove entries
> -# from the COMPILER list if they're known to not work.
> +# Standard for C++ ports:
> #COMPILER = base-clang ports-gcc base-gcc
> +# Standard for C++11 or newer:
> +#COMPILER = base-clang ports-gcc
> +# Ports that require a non-default compiler that do *not* use C++ should set
> this:
> +#COMPILER_LANGS = c
> +
> +# Dependencies
> #MODULES = ???
> #BUILD_DEPENDS = ???
> #RUN_DEPENDS = ???
>