Re: productivity/tryton: add cdn to MASTER_SITES

On 2019/07/24 08:42, Sebastien Marie wrote:
> Hi,
>
> tryton upstream added a cdn in front of their downloads.tryton.org host
> to reduce the load for serving static files.
>
> The following diff makes all tryton ports uses downloads-cdn.t.o first,
> and next fallback to downloads.t.o.
>
> I assume changing MASTER_SITES doesn't require to bump REVISION.

Correct.

> I checked that the tarballs are the same (make fetch doesn't complain
> about change in hashes).
>
> Comments or OK ?

OK.

Is it even worth keeping the fallback? In most cases CDN should be a no-brainer
for distfiles, we only have problems with ours because we update files without
changing the URL. I don't mind either way though.



> --
> Sebastien Marie
>
>
> Index: Makefile.inc
> ===================================================================
> RCS file: /cvs/ports/productivity/tryton/Makefile.inc,v
> retrieving revision 1.27
> diff -u -p -r1.27 Makefile.inc
> --- Makefile.inc 2 Jul 2019 10:21:26 -0000 1.27
> +++ Makefile.inc 24 Jul 2019 06:38:18 -0000
> @@ -10,7 +10,8 @@ MAINTAINER ?= Sebastien Marie <semarie@
> # GPLv3
> PERMIT_PACKAGE ?= Yes
>
> -MASTER_SITES = https://downloads.tryton.org/${VERSION:C/^([0-9]+\.[0-9]+).*/\1/}/
> +MASTER_SITES = https://downloads-cdn.tryton.org/${VERSION:C/^([0-9]+\.[0-9]+).*/\1/}/ \
> + https://downloads.tryton.org/${VERSION:C/^([0-9]+\.[0-9]+).*/\1/}/
> DIST_SUBDIR = tryton
>
> VERSION ?= ${MODPY_EGG_VERSION}
>