Friday, August 02, 2019

FIX: x11/gnome/gedit (was: sparc64 bulk build report)

Index: Makefile
===================================================================
RCS file: /cvs/ports/x11/gnome/gedit/Makefile,v
retrieving revision 1.163
diff -u -p -r1.163 Makefile
--- Makefile 7 Jul 2019 11:20:52 -0000 1.163
+++ Makefile 3 Aug 2019 01:47:43 -0000
@@ -42,6 +42,8 @@ MODPY_VERSION= ${MODPY_DEFAULT_VERSION_
MODGNOME_TOOLS += desktop-file-utils gobject-introspection \
gtk-update-icon-cache vala yelp

+CONFIGURE_ENV = CFLAGS="${CFLAGS} -std=c99"
+
TEST_IS_INTERACTIVE= X11

.include <bsd.port.mk>
Hi ports --

The latest sparc64 build shows that x11/gnome/gedit fails to build. See [0].
This is because it is using base-gcc and the codebase uses C99
constructs without using the -std=c99/gnu99 flags. Clang doesn't need
this because it defaults to C99. If we add the -std=c99 flag, then
base-gcc is happy and it's a no-op for clang.

Build tested only on amd64 by forcing CC=gcc. But it does build (and the
build works).

OK?

~Brian

[0]
http://build-failures.rhaalovely.net//sparc64/2019-08-01/x11/gnome/gedit.log

No comments:

Post a Comment