Re: NEW: mail/dma

On 8/1/19 2:16 PM, Klemens Nanni wrote:
> On Mon, Jul 29, 2019 at 09:19:48PM -0400, Brian Callahan wrote:
>> Added mailer.conf as an example config.
>> I thought I had included dma.conf but I guess not. It's there now. Both
>> dma.conf and auth.conf are @sample'd into the correct place
>> (${SYSCONFDIR}/dma/) but I chose not to @sample mailer.conf, as systems come
>> with a /etc/mailer.conf by default.
> Seems good.
>
>> I did. This port is my own fork of dma because of a bunch of FreeBSD/DFly
>> compat that had to be included and I would have to modify either Makefile no
>> matter which way I went so I chose to modify ${WRKSRC}/Makefile to make my
>> life easier. So I simply did the right thing for an install target in
>> ${WRKSRC}/Makefile too now so the do-install target goes away.
>>
>> Additionally, there are some fixes in the updated attached tarball.
> Your new tarball lacks a `do-install' target but has no patches to any
> Makefile, does that mean you incorporated the fixes into your tarball?

Correct.

> A bit confusing because I have no way to tell which bits came from
> upsreamand which ones you added/modified.
>
> That said, if it's your fork I'd prefer upstream (you) to carry
> modifications instead of having them under patches/ in the port, but
> some from of comment or DESCR addition stating that could be helpful.
> Especially since you link to Dragonfly's official site as HOMEPAGE, not
> yours.

Notably because I don't have a homepage for it :) I could throw up a
github fork if that makes things easier for people. Either way, the DFly
site is a better HOMEPAGE than a github page. But I could leave a note
in DESCR saying that it's a fork that sounds good.

~Brian