Re: [new] x11/alacritty

On Sat, Aug 3, 2019 at 2:01 AM Brian Callahan <callab5@rpi.edu> wrote:
>
> Hi Eric --
Hello Brian,

answers inlined.
>
> On 8/1/19 1:56 PM, Eric Augé wrote:
> > Hello,
> >
> > This is a new port of gpu accelerated terminal emulator written in rust:
> > https://github.com/jwilm/alacritty
> >
> > portcheck seems ok, I was not sure about adding or not the completion
> > or how to check for the presence of zsh / fish / bash before
> > installing those completions files.
> >
> > also afaik this is amd64 only, but I'm not sure how to mention that in
> > the Makefile.
> > please let me know if any changes are needed and if that could makes
> > its way in ports?
> >
> > hth,
> > Eric.
>
> Thanks for this. Alacritty was on my list. Glad I don't have to do it now.
>
> Here is an updated tarball, with some necessary and convenience tweaks:
> * Reel in excess whitespace

Oops :)

> * Make the list of cargo crates easier to read at a glance (wow that's a
> long list!)
> * Rearrange variables
> * Sync WANTLIB

Thanks, btw do we need to have USE_X11 ?

> Things that are still needed:
> * A comment to say why the do-install is needed. Is it that upstream
> doesn't provide one?

Hmm the documentation, mainly give you manual steps and generate a
package base for debian only, even the manpage must be copied by hand,
the Makefile provide an install target,
but it is mainly to open the dmg on os/x, so I did not find an
"install" as such and assumed, following is the install steps from
the alacritty project:

https://github.com/jwilm/alacritty/blob/master/INSTALL.md

Additionally on OpenBSD, there is a comment on alacritty project:
"The default user limits in OpenBSD are insufficient to build
Alacritty. A datasize-cur of at least 3GB is recommended (see
login.conf)."

How should I deal with this from the port POV?

> * Missing a MAINTAINER line. Would you like to be maintainer?
yes, I can do that, I've added the line to the Makefile, ok?

> * A better pkg/DESCR
I mainly copied the headline from the project itself, the rest being
kinda "marketing'y", should I put the complete project description or
should I make a slightly modified/longer version of the short one?
something like:

"
Alacritty is a cross platform, GPU accelerated terminal emulator with
a strong focus on simplicity and performance.
It provides sane choices for defaults and requires no additional
setup. However, it does allow configuration of many aspects of the
terminal.
The software is considered to be at a beta level of readiness -- there
are a few missing features and bugs to be fixed, but it is already
used by many as a daily driver.
"
ok?

> * `make test' is broken. It looks like there's some missing LDFLAGS on
> -L${X11BASE}/lib

I've added a MODCARGO_RUSTFLAGS described in port-modules(5) and make
test runs ok now.

>
> ~Brian
HTH,
Eric.

Attached is a new version of the port (integrating Stuart comments on
crates license), ok?