Re: UPDATE: java/gradle 5.6.2

On 2019/09/16 22:13, Lawrence Teo wrote:
> This updates Gradle to 5.6.2.
>
> https://docs.gradle.org/5.6.2/release-notes.html
>
> I have confirmed that security/ghidra builds with this Gradle update.
>
> To make future updates easier, this diff also adds myself as maintainer
> since security/ghidra (which I currently maintain) is the only port that
> uses Gradle right now.
>
> ok?

OK.

> +++ pkg/PLIST 15 Sep 2019 14:58:33 -0000
> @@ -23,41 +23,41 @@ share/java/gradle/lib/commons-io-2.6.jar
> share/java/gradle/lib/commons-lang-2.6.jar
> share/java/gradle/lib/failureaccess-1.0.1.jar
> share/java/gradle/lib/fastutil-8.2.1-min.jar
> -share/java/gradle/lib/gradle-api-metadata-5.6.jar
..snip..
> +share/java/gradle/lib/gradle-api-metadata-5.6.2.jar

To make plist diffs a bit less noisy for future updates (which in turn
makes it easier to notice what has changed), what do you think about
using a variable to replace the gradle version number? You could do e.g.

GRADLE_JAR= ${DISTNAME:S/gradle//}.jar
SUBST_VARS+= GRADLE_JAR

so for 5.6.2 GRADLE_JAR would be set to -5.6.2.jar (with the - and .jar
literals to avoid a bogus match), and these plist entries would then
look like [...]/lib/gradle-api-metadata${GRADLE_JAR}
A