Re: databases/lmdb: add pkg-config lmdb.pc

On Mon, Oct 07 2019, Christopher Zimmermann <chrisz@openbsd.org> wrote:
> Hi,

Hi,

> can this go in now or should I wait until after ports lock?

After ports lock. I know that at least newer samba versions depend on
the pkgconfig file to detect LMDB; other ports may do so.

Can you please give a rationale / use case? Are some projects requiring
this because some Linux distros started to ship a .pc not provided by
upstream?

Nit below,

> Christopher
>
>
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/databases/lmdb/Makefile,v
> retrieving revision 1.7
> diff -u -p -r1.7 Makefile
> --- Makefile 22 Jun 2019 22:44:06 -0000 1.7
> +++ Makefile 7 Oct 2019 16:03:41 -0000
> @@ -3,7 +3,7 @@
> COMMENT = Symas Lightning Memory-Mapped Database
>
> VERSION = 0.9.23
> -REVISION = 0
> +REVISION = 1
>
> GH_ACCOUNT = LMDB
> GH_PROJECT = lmdb
> @@ -31,5 +31,10 @@ MAKE_FLAGS = CC="${CC}" XCFLAGS="${CFLA
> SHARED_VERSION_MINOR=${LIBlmdb_VERSION:E}
>
> WRKDIST = ${WRKDIR}/lmdb-${GH_TAGNAME}/libraries/liblmdb
> +
> +SUBST_VARS += VERSION
> +
> +post-install:
> + ${SUBST_CMD} -c -m 0444 ${FILESDIR}/lmdb.pc ${PREFIX}/lib/pkgconfig/liblmdb.pc

This ought to use -m ${SHAREMODE}.

>
> .include <bsd.port.mk>
> Index: files/lmdb.pc
> ===================================================================
> RCS file: files/lmdb.pc
> diff -N files/lmdb.pc
> --- /dev/null 1 Jan 1970 00:00:00 -0000
> +++ files/lmdb.pc 7 Oct 2019 16:03:41 -0000
> @@ -0,0 +1,11 @@
> +prefix=${LOCALBASE}
> +exec_prefix=${prefix}/bin
> +libdir=${prefix}/lib
> +includedir=${prefix}/include
> +
> +Name: liblmdb
> +Description: Lightning Memory-Mapped Database
> +URL: https://symas.com/products/lightning-memory-mapped-database/
> +Version: ${VERSION}
> +Libs: -L${libdir} -llmdb
> +Cflags: -I${includedir}
> Index: pkg/PLIST
> ===================================================================
> RCS file: /cvs/ports/databases/lmdb/pkg/PLIST,v
> retrieving revision 1.1.1.1
> diff -u -p -r1.1.1.1 PLIST
> --- pkg/PLIST 6 Jun 2018 10:34:28 -0000 1.1.1.1
> +++ pkg/PLIST 7 Oct 2019 16:03:41 -0000
> @@ -6,6 +6,7 @@
> include/lmdb.h
> lib/liblmdb.a
> @lib lib/liblmdb.so.${LIBlmdb_VERSION}
> +lib/pkgconfig/liblmdb.pc
> @man man/man1/mdb_copy.1
> @man man/man1/mdb_dump.1
> @man man/man1/mdb_load.1

--
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE