Re: games/ace crashes

On Tue, 1 Oct 2019 18:04:49 +0200
Solene Rapenne wrote:

> on amd64, few days old snap (I can't upgrade now for some reasons..)

The build log complains about:

imagelib.c:109:17: warning: implicit declaration of function 'malloc' is
invalid in C99 [-Wimplicit-function-declaration]

Clang uses C11 by default, that's probably why it works fine on macppc
with the good^W old base-gcc, that uses gnu89 by default.

So i added the header and... it works :]

Feedback is welcome!

Charlène.


Index: Makefile
===================================================================
RCS file: /cvs/ports/games/ace/Makefile,v
retrieving revision 1.4
diff -u -p -u -p -r1.4 Makefile
--- Makefile 12 Jul 2019 20:46:14 -0000 1.4
+++ Makefile 2 Oct 2019 13:17:54 -0000
@@ -3,7 +3,7 @@
COMMENT = solitaire games

DISTNAME = ace-1.4
-REVISION = 0
+REVISION = 1

SHARED_LIBS += cards 0.0 # 1.0

Index: patches/patch-lib_imagelib_c
===================================================================
RCS file: patches/patch-lib_imagelib_c
diff -N patches/patch-lib_imagelib_c
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ patches/patch-lib_imagelib_c 2 Oct 2019 13:17:54 -0000
@@ -0,0 +1,11 @@
+$OpenBSD$
+
+Index: lib/imagelib.c
+--- lib/imagelib.c.orig
++++ lib/imagelib.c
+@@ -1,4 +1,5 @@
+ #include <stdio.h>
++#include <stdlib.h>
+ #include <string.h>
+ #include "imagelib.h"
+ #include "cards.h"