On Tue, Jan 28 2020, George Koehler <kernigh@gmail.com> wrote:
> Hello ports!
Hi George :)
[...]
I'm happy to see you move on with this diff. I don't have a powerpc
machine at hand so I'll trust you regarding the correctness of the
resulting object code. If you want double checks here I'd suggest
talking to kettenis@ (maybe others).
Two things came to my mind regarding your diff:
- on reviews.llvm.org you say this affects OpenBSD, NetBSD and FreeBSD,
but your code changes the default for anything ELF+non-Linux:
> ++ if (Triple.isOSBinFormatELF() && !Triple.isOSLinux())
> ++ return true;
Are there only four platforms supported? Would it be safer to
explicitely change the default on *BSD?
- I guess you did not choose the name of the options randomly. Lazy
question: were SVR4 and AIX the first users of those ABI variants?
Or is there another reason?
> I'm still waiting for my iMac to build this. Later, I might try to
> apply this diff to base-clang. I won't commit this diff to ports-clang
> before I know what to do with base-clang.
Ack.
--
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
No comments:
Post a Comment