Re: ncmpcpp dumps core when fetching lyrics

On 2020/09/12 12:36, Erling Westenvik wrote:
> On Fri, Sep 11, 2020 at 10:09:25PM +0100, Stuart Henderson wrote:
> > [moving to ports@openbsd.org list]
> > On 2020-09-11, Ashlen <eurydice@riseup.net> wrote:
> > > Sorry Stuart, I think I accidentally replied to you directly the first
> > > time I sent this. I'm still getting used to neomutt.
> >
> > No problem, for mailing lists you usually want 'group-reply'
> > (by default this is bound to 'g' in mutt/neomutt).
>
> And I accidentally sent my previous reply as 'list-reply' ('L') to @misc..
>
> > This is likely a bug in ncmpcpp. Not sure if it's the same
> > thing but I found https://github.com/ncmpcpp/ncmpcpp/issues/394
> > which referenced https://github.com/ncmpcpp/ncmpcpp/issues/396
> > so I think the first step is to try a newer version.
> > Here's a ports diff to update it to git head, it builds OK but
> > I don't have any mpd setup so no idea how well/if it works.
>
> Thanks for the diff. Ncmpcpp still crashes when trying to fetch lyrics though.
> Gdb output with last version and after rebuilding with debug flags:

Since the problem still exists in git head, I think it would be worth
reporting this upstream.

> [...]
> Program terminated with signal SIGBUS, Bus error.
> #0 _libc_pthread_mutex_unlock (mutexp=<optimized out>) at /usr/src/lib/libc/thread/rthread_mutex.c:246
> 246 (void *)mutex->owner);
> (gdb) bt
> #0 _libc_pthread_mutex_unlock (mutexp=<optimized out>) at /usr/src/lib/libc/thread/rthread_mutex.c:246
> #1 0x00000f7389525277 in std::__1::__libcpp_mutex_unlock (__m=0xf73b8ff2d18) at /usr/src/lib/libcxx/include/__threading_support:266
> #2 std::__1::mutex::unlock (this=0xf73b8ff2d18) at /usr/src/lib/libcxx/src/mutex.cpp:45
> #3 0x00000f713119422d in std::__1::unique_lock<std::__1::mutex>::~unique_lock (this=<optimized out>) at /usr/include/c++/v1/__mutex_base:153
> #4 Shared<NC::BasicBuffer<char> >::Resource::~Resource (this=<optimized out>) at ./utility/shared_resource.h:29
> #5 Lyrics::update (this=0xf740afb5c00) at screens/lyrics.cpp:236
> #6 0x00000f71311f2215 in std::__1::__function::__value_func<void (BaseScreen*)>::operator()(BaseScreen*&&) const (this=0x7f7ffffd4500,
> __args=<optimized out>) at /usr/include/c++/v1/functional:1799
> #7 std::__1::function<void (BaseScreen*)>::operator()(BaseScreen*) const (this=0x7f7ffffd4500, __arg=0xf740afb5c00) at /usr/include/c++/v1/functional:2347
> #8 applyToVisibleWindows(std::__1::function<void (BaseScreen*)>) (f=...) at screens/screen.cpp:135
> #9 0x00000f71312d8ad8 in Status::trace (update_timer=<optimized out>, update_window_timeout=<optimized out>) at status.cpp:236
> #10 0x00000f7131249a13 in Actions::UpdateEnvironment::run (this=0x7f7ffffd48c8, update_timer=24, refresh_window=<optimized out>, mpd_sync=<optimized out>)
> at actions.cpp:338
> #11 0x00000f71312ae220 in main (argc=<optimized out>, argv=<optimized out>) at ncmpcpp.cpp:217
> (gdb)
>
> Erling