Sunday, October 25, 2020

[PATCH] Try unbreaking devel/libexecinfo on mips64*

Index: Makefile
===================================================================
RCS file: /cvs/ports/devel/libexecinfo/Makefile,v
retrieving revision 1.26
diff -u -p -r1.26 Makefile
--- Makefile 3 Jan 2020 15:16:59 -0000 1.26
+++ Makefile 25 Oct 2020 08:55:37 -0000
@@ -9,7 +9,7 @@ GH_PROJECT= backtrace
DISTNAME = ${GH_PROJECT}-${V}
PKGNAME = libexecinfo-$V
EPOCH = 0
-REVISION = 2
+REVISION = 3
CATEGORIES = devel

SHARED_LIBS = execinfo 2.0
@@ -27,7 +27,8 @@ FAKE_FLAGS = PREFIX=${WRKINST}/${TRUEPRE
MANDIR=${PREFIX}/man/man

.if ${MACHINE_ARCH:Mmips64*} || ${MACHINE_ARCH:Mhppa} || ${MACHINE_ARCH:Msh}
-CFLAGS+= -D__BUILTIN_HACK
+COMPILER= ports-gcc base-gcc
+CFLAGS+= -D__BUILTIN_HACK -Wno-frame-address
.endif

do-configure:
Hi,

On mips64el, 'make test' currently fails in devel/libexecinfo with the
following error:

===> Regression tests for libexecinfo-0.3p2v0
/usr/bin/env -i \
LD_LIBRARY_PATH=/usr/ports/pobj/libexecinfo-0.3/backtrace-BACKTRACE_0_3/libbacktrace \
/usr/ports/pobj/libexecinfo-0.3/backtrace-BACKTRACE_0_3/examples/backtrace_test
backtrace_test: backtrace_symbols

mips64el still uses gcc-4.2.1 by default, at the moment.

The test works again with ports-gcc, but you need -Wno-frame-address so
that the __BUILTIN_HACK part builds with -Werror.

I also see that clang (with is used by default on mips64) is having
issues compiling this:

http://build-failures.rhaalovely.net/mips64/2020-10-14/devel/libexecinfo.log

So hopefully, the attached diff fixes both issues.

Only tested on OpenBSD/loongson 6.8, though. No idea for hppa, sh,
or if this ports-gcc dependency could cause bootstrapping problems.

Donovan

No comments:

Post a Comment