Re: [macppc] Don't build x11/kitty

On 10/4/2020 9:45 AM, Charlene Wendling wrote:
> On Sun, 4 Oct 2020 01:12:35 -0400
> Brad Smith wrote:
>
>> On 10/4/2020 1:01 AM, Thomas Frohwein wrote:
>>> On Wed, Sep 30, 2020 at 05:51:05PM +0200, Charlene Wendling wrote:
>>>> Hi,
>>>>
>>>> (This can wait post-release, the wasted time is low)
>>>>
>>>> Kitty is broken in the current macppc bulk:
>>>>
>>>>> cc -MMD -DNDEBUG -Wextra -Wfloat-conversion
>>>>> -Wno-missing-field-initializers -Wall -Wstrict-prototypes -std=c11
>>>>> -pedantic-errors -Werror -fwrapv -fstack-protector-strong -pipe
>>>>> -fvisibility=hidden -D_FORTIFY_SOURCE=2 -fPIC -O2 -pipe -flto
>>>>> -pthread -Ikitty -I/usr/local/include/python3.8 -c
>>>>> kittens/choose/score.c -o
>>>>> build/subseq_matcher-score.c.obuild/fast_data_types-charsets.c.o:
>>>>> file not recognized: File format not recognized
>>>> My first guess was to disable LTO by doing a debug build (see
>>>> setup.py:289 for rationale), and i managed to package kitty like
>>>> that.
>>>> At runtime i'm greeted with:
>>>>
>>>>> [274 17:24:38.489771] [glfw error 65543]: GLX: Failed to create
>>>>> context: GLXBadFBConfig
>>>>> [274 17:24:38.496529] Failed to create GLFW temp window! This
>>>>> usually happens because of old/broken OpenGL drivers. kitty
>>>>> requires working OpenGL 3.3 drivers.
>>>> And it quits. No macppc machine should be OpenGL 3.3 capable using
>>>> hardware acceleration. With software rendering it leads to floating
>>>> point exceptions or system lockups, and would be very slow anyway.
>>>>
>>>> I'm proposing to not build it on macppc.
>>> ok thfr@
>>>
>>>> Comments/feedback are welcome,
>>>>
>>>> Charlène.
>>>>
>>>>
>>>> Index: Makefile
>>>> ===================================================================
>>>> RCS file: /cvs/ports/x11/kitty/Makefile,v
>>>> retrieving revision 1.2
>>>> diff -u -p -u -p -r1.2 Makefile
>>>> --- Makefile 7 Sep 2020 12:53:00 -0000 1.2
>>>> +++ Makefile 30 Sep 2020 15:37:32 -0000
>>>> @@ -1,5 +1,8 @@
>>>> # $OpenBSD: Makefile,v 1.2 2020/09/07 12:53:00 sthen Exp $
>>>>
>>>> +# Requires OpenGL>=3.3
>>>> +NOT_FOR_ARCHS = powerpc
>>>> +
>>>> COMMENT = fast, feature full, GPU-based terminal
>>>> emulator
>>>> MODPY_EGG_VERSION = 0.18.3
>>
>> Looking at the system requirements it would be better to flip this
>> around to using ONLY_FOR_ARCHS with amd64 and i386 for now.
>>
> You're right, i added aarch64 as i did in games/taisei, that has the
> same requirement.
>
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/x11/kitty/Makefile,v
> retrieving revision 1.2
> diff -u -p -u -p -r1.2 Makefile
> --- Makefile 7 Sep 2020 12:53:00 -0000 1.2
> +++ Makefile 4 Oct 2020 13:44:56 -0000
> @@ -1,5 +1,8 @@
> # $OpenBSD: Makefile,v 1.2 2020/09/07 12:53:00 sthen Exp $
>
> +# Requires OpenGL>=3.3
> +ONLY_FOR_ARCHS = aarch64 amd64 i386
> +
> COMMENT = fast, feature full, GPU-based terminal emulator
>
> MODPY_EGG_VERSION = 0.18.3

That doesn't make sense. There are no hardware accelerated drivers on
aarch64.