Wednesday, October 28, 2020

Re: [macppc] x11/gnustep/*: fix make, mark base BROKEN

On Thu, 8 Oct 2020 01:08:05 +0200
Charlene Wendling <julianaito@posteo.jp> wrote:

> Hi,
>
> Here are the current gnustep/libobjc failures:
>
> http://build-failures.rhaalovely.net/powerpc/2020-08-23/www/sope.log
> http://build-failures.rhaalovely.net/powerpc/2020-08-23/x11/gnustep/dbuskit.log
> http://build-failures.rhaalovely.net/powerpc/2020-08-23/x11/gnustep/gui.log
> http://build-failures.rhaalovely.net/powerpc/2020-08-23/x11/gnustep/performance.log
>
> So i'm asking again if i can go ahead so it doesn't waste bulk time.
>
> Charlène.

I'm sorry for replying 3 weeks after your mail. Your diff (from
April!), quoted below, would have marked gnustep-base BROKEN-powerpc
and changed gnustep-make on powerpc.

I now have a clang diff (https://reviews.llvm.org/D90329) that
unbreaks gnustep-base and gnustep-make without needing your diff.
Last week, Anthony Richardby had found and reported the bug that
broke clang's va_arg(_, id) in Objective-C code. With the clang diff,
and using FETCH_PACKAGES=, I built x11/gnustep/{libobjc2,make,base,
gui,gmines} and played gmines.

Later, I will mail the clang diff to tech@, but now, it isn't in
OpenBSD's clang, so ok gkoehler@ to mark base BROKEN-powerpc if you
don't want to wait for the fix.

I didn't ok your gnustep/make diff because I'm not sure. I don't know
why amd64 and i386 have the different LIBRARY_COMBO. Also, AS=llvm-as
looks wrong because ports-clang (for llvm-as) might not be installed.

The clang diff affects only 32-bit powerpc. Something else is wrong
on powerpc64 (where most gnustep packages are missing), but I have
not yet tried a powerpc64 build. --George

>
> Index: base/Makefile
> ===================================================================
> RCS file: /cvs/ports/x11/gnustep/base/Makefile,v
> retrieving revision 1.75
> diff -u -p -r1.75 Makefile
> --- base/Makefile 20 Oct 2019 08:03:00 -0000 1.75
> +++ base/Makefile 18 Apr 2020 15:46:55 -0000
> @@ -1,5 +1,7 @@
> # $OpenBSD: Makefile,v 1.75 2019/10/20 08:03:00 ajacoutot Exp $
>
> +BROKEN-powerpc= consumers segfault at runtime
> +
> COMMENT= GNUstep base library
>
> DISTNAME= gnustep-base-1.26.0
> Index: make/Makefile
> ===================================================================
> RCS file: /cvs/ports/x11/gnustep/make/Makefile,v
> retrieving revision 1.56
> diff -u -p -r1.56 Makefile
> --- make/Makefile 20 Oct 2019 08:03:03 -0000 1.56
> +++ make/Makefile 18 Apr 2020 15:46:55 -0000
> @@ -36,7 +36,8 @@ CONFIGURE_ARGS= --with-layout=openbsd \
> --with-objc-lib-flag=-lobjc2 \
> --enable-strict-v2-mode
>
> -.if ${MACHINE_ARCH} == "amd64" || ${MACHINE_ARCH} == "i386"
> +.if ${MACHINE_ARCH} == "amd64" || ${MACHINE_ARCH} == "i386" || \
> + ${MACHINE_ARCH} == "powerpc"
> WANTLIB = ${COMPILER_LIBCXX}
> LIBRARY_COMBO = "ng-gnu-gnu"
> CONFIGURE_ENV += GS_WITH_ARC=1 AS=llvm-as
>


--
George Koehler <kernigh@gmail.com>

No comments:

Post a Comment