Re: [NEW] sysutils/docker 19.03.13

On Sat, 3 Oct 2020 13:58:17 +0100
Stuart Henderson <stu@spacehopper.org>:

> On 2020/10/03 14:01, Solene Rapenne wrote:
> > On Sat, 3 Oct 2020 13:59:33 +0200
> > Solene Rapenne <solene@perso.pw>:
> >
> > > On Tue, 22 Sep 2020 22:41:26 +0200
> > > Muhammad Kaisar Arkhan <hi@yukiisbo.red>:
> > >
> > > > Hello,
> > > >
> > > > Attached is a port of the command line utility for Docker, specifically
> > > > version v19.03.13.
> > > >
> > > > This is created in the same spirit as sysutils/kubectl, allowing OpenBSD
> > > > users to interact with Docker servers from their OpenBSD systems.
> > > >
> > > > OK?
> > > >
> > >
> > > I'm fine for importing it. I made a few aesthetics changes to the
> > > Makefile but the port looks good to me and works well.
> > >
> > > anyone else ok?
> > >
> >
> > forgot to include the patch about my small changes
> > Only an additional tab and variable reordering.
>
> > --- sysutils/docker/Makefile Tue Sep 22 22:26:58 2020
> > +++ Makefile Sat Oct 3 13:44:49 2020
> > @@ -1,16 +1,15 @@
> > # $OpenBSD$
> >
> > -COMMENT = command-line tool for controlling Docker
> > +COMMENT = command-line tool for controlling Docker
> >
> > +V = 19.03.13
> > +PKGNAME = docker-${V}
> > +
> > GH_ACCOUNT = docker
> > GH_PROJECT = cli
> > -V = 19.03.13
> > GH_TAGNAME = v${V}
> > -PKGNAME = docker-${V}
>
> To avoid confusion I think this port and package should be named
> docker-cli not docker, this would work:
>
> V = 19.03.13
> GH_ACCOUNT = docker
> GH_PROJECT = cli
> GH_TAGNAME = v${V}
> PKGNAME = docker-${DISTNAME}
>
> > -HOMEPAGE = https://docs.docker.com/engine/reference/commandline/cli/
>
> That seems a better homepage than https://github.com/docker/cli which
> is what you'll get by removing it.
>

I agree with what you said. I thought having the github HOMEPAGE
would be better but I don't have a strong opinion about this.