Re: new: sysutils/mdf2iso

On 2020/10/28 15:22, zeurkous@volny.cz wrote:
> #?patch
> #
> # (There seems to be a bug in diff(1) that causes the mandatory (yet
> # admittedly empty) pkg/DESCR file to be omitted. Just touch(1) it
> # yourself...)

a blank pkg/DESCR is not acceptable.

> # These patches add mdf2iso to the OpenBSD ports(7) tree.
> #
> # --zeurkous, Wed Oct 28 14:15:48 UTC 2020.
> #
> diff -Nru /var/empty/Makefile ports/sysutils/mdf2iso/Makefile

send tarballs not diffs for new ports please.

> --- /var/empty/Makefile Thu Jan 1 00:00:00 1970
> +++ ports/sysutils/mdf2iso/Makefile Wed Oct 28 14:09:18 2020
> @@ -0,0 +1,24 @@
> +COMMENT= Alcohol 120% to ISO9660 image converter
> +
> +MASTER_SITES= https://gitlab.com/bsdforge/mdf2iso/-/archive/master/
> +DISTNAME= mdf2iso-master
> +EXTRACT_SUFX= .tar.gz
> +VER= 20201028
> +PKGNAME= mdf2iso-${VER}

this points directly at a checkout generated from master which is
a moving target. it needs to point at something that does not change
when a commit is made upstream (I know it has been inactive for some
years but we don't know what might happen later to break the port).
use a tag or a commit id.

> +
> +CATEGORIES= sysutils
> +
> +# GPLv2
> +PERMIT_PACKAGE= Yes
> +
> +WANTLIB= c
> +
> +CONFIGURE_STYLE=gnu
> +
> +post-extract:
> + cp ${FILESDIR}/Makefile-doc ${WRKSRC}
> +
> +post-install:
> + cd ${WRKSRC} && ${MAKE} -f Makefile-doc install

you are already in a Makefile there's no need for indirection to a
separate file. just put the targets directly in post-install the same
way every other port in the tree that uses post-install targets does it.

> +
> +.include <bsd.port.mk>
>
> diff -Nru /var/empty/distinfo ports/sysutils/mdf2iso/distinfo
> --- /var/empty/distinfo Thu Jan 1 00:00:00 1970
> +++ ports/sysutils/mdf2iso/distinfo Wed Oct 28 13:50:38 2020
> @@ -0,0 +1,2 @@
> +SHA256 (mdf2iso-master.tar.gz) = Wa6+azbVtgZa031VSP4n/gbs90OCFRy5ef7YH3dxFi8=
> +SIZE (mdf2iso-master.tar.gz) = 193384
>
> diff -Nru /var/empty/files/Makefile-doc ports/sysutils/mdf2iso/files/Makefile-doc
> --- /var/empty/files/Makefile-doc Thu Jan 1 00:00:00 1970
> +++ ports/sysutils/mdf2iso/files/Makefile-doc Wed Oct 28 13:57:33 2020
> @@ -0,0 +1,8 @@
> +#!/usr/bin/make -f
> +
> +all:
> +
> +install:
> + ${INSTALL} -d -m 755 ${PREFIX}/share/doc/mdf2iso/
> + ${INSTALL} -c -m 644 ChangeLog README.md gpl.txt\
> + ${PREFIX}/share/doc/mdf2iso/
>
> diff -Nru /var/empty/pkg/PLIST ports/sysutils/mdf2iso/pkg/PLIST
> --- /var/empty/pkg/PLIST Thu Jan 1 00:00:00 1970
> +++ ports/sysutils/mdf2iso/pkg/PLIST Wed Oct 28 14:00:58 2020
> @@ -0,0 +1,6 @@
> +@comment $OpenBSD: PLIST,v$
> +@bin bin/mdf2iso
> +share/doc/mdf2iso/
> +share/doc/mdf2iso/ChangeLog
> +share/doc/mdf2iso/README.md
> +share/doc/mdf2iso/gpl.txt
>