Re: Okay to drop Python 2 support to unbreak scikit-learn with Python 3.8?

On Tue, 27 Oct 2020, James Cook wrote:

> On Sun, Oct 25, 2020 at 11:44:29AM -0400, Daniel Dickman wrote:
> > Hi James,
> >
> > Not sure if you're still looking into this or not, but I took another stab
> > at it. See attached for new a new port for py-threadpoolctl and an sklearn
> > diff.
> >
> > I tried to run the regress tests, but it core dumped about half way in for
> > me... which is still better than the current situation where it bails
> > directly after "import sklearn".
> >
> > Does this work any better for you?
> >
> > Paul, any thoughts? Can this go in?
>
> Thanks! It works fine with my own use-case, which is running
> beancount-import.
>
> However I did notice "make test" also fails for py-threadpoolctl.
>
> Below I've included two pieces of "make test" output...
>
> 1. The end of "make test" output for py-threadpoolctl, but with a bunch
> of source code replaced with "...":
>
> tests/test_threadpoolctl.py:417:
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> /usr/local/lib/python3.8/subprocess.py:489: in run
> with Popen(*popenargs, **kwargs) as process:
> /usr/local/lib/python3.8/subprocess.py:854: in __init__
> self._execute_child(args, executable, preexec_fn, close_fds,
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
>
> ...
>
> if errno_num != 0:
> err_msg = os.strerror(errno_num)
> > raise child_exception_type(errno_num, err_msg, err_filename)
> E FileNotFoundError: [Errno 2] No such file or directory: 'python'
>
> /usr/local/lib/python3.8/subprocess.py:1702: FileNotFoundError

its not a real problem for running anything, but the tests can be made to
pass with s/python/python3/ in tests/test_threadpoolctl.py