Re: stlink port?

On 2020/10/26 16:03, adr@SDF.ORG wrote:
> Hello,
>
> this is a port of https://github.com/stlink-org/stlink:
>
> "STLink is an open source toolset to program and debug STM32 devices
> and boards manufactured by STMicroelectronics. It supports several
> so called STLINK programmer boards (and clones thereof) which use
> a microcontroller chip to translate commands from USB to JTAG/SWD."
>
> I could separate the gui in another package or use flavors if there
> is any interest in the port.
>
> I'm not offering myself as the maintainer because I'm not a cmake
> user.
>
> Regards,
> adr.

: V = 1.6.1
: DISTNAME = v${V}
: PKGNAME = stlink-${V}
...
: HOMEPAGE = https://github.com/stlink-org/stlink
...
: MASTER_SITES = https://github.com/stlink-org/stlink/archive/
...
: WRKDIST = ${WRKDIR}/${PKGNAME}

Replace all the above lines with

GH_ACCOUNT = stlink-org
GH_PROJECT = stlink
GH_TAGNAME = v1.6.1

and regenerate distinfo so it has a sane filename.

(Makefile.template tries to explain this but I think nobody reads it...)

: post-build:
: @cd ${WRKBUILD}/bin/; strip -s st-flash st-info st-util stlink-gui

Don't unconditionally strip, this should only be done under control of
ports. Normally this is handled automatically in the "make install"
stage by ports infrastructure.

This entry in cmake/modules/c_flags.cmake should be removed too, ports should
be in control of the opt level:

cmake/modules/c_flags.cmake
51: add_cflag_if_supported("-O2")