Tuesday, February 02, 2021

Re: New port: Gaupol subtitle editor

start COMMENT with lower-case please (unless it's a proper noun,
but that doesn't apply here).

we are a bit busy fixing hundreds of ports for a forthcoming
clang update at the moment so it may take a while to get to it :)


On 2021/02/02 06:41, Anindya Mukherjee wrote:
> Attached tarball.
>
>
> From: Anindya Mukherjee <anindya49@hotmail.com>
> Sent: February 1, 2021 10:31 PM
> To: Dimitri Karamazov <deserter666@danwin1210.me>
> Cc: ports@openbsd.org <ports@openbsd.org>
> Subject: Re: New port: Gaupol subtitle editor
>  
> Hi, just to recap:
>
> This package provides Gaupol, an editor for
>  text-based subtitle files.
>
> Maintainer: Anindya Mukherjee <anindya49@hotmail.com>
>
> Homepage: https://otsaloma.io/gaupol/
>
> Comments? OKs? I'm using it on my machine,
> installed from pkg.
>
> Thanks!
> Anindya
>
>
> From: Anindya Mukherjee <anindya49@hotmail.com>
> Sent: January 29, 2021 7:18 PM
> To: Dimitri Karamazov <deserter666@danwin1210.me>
> Cc: ports@openbsd.org <ports@openbsd.org>
> Subject: Re: New port: Gaupol subtitle editor
>  
> Updated tarball attached. I have added myself as
> maintainer.
>
> Thanks,
> Anindya
>
>
> From: Anindya Mukherjee <anindya49@hotmail.com>
> Sent: January 29, 2021 12:04 AM
> To: Dimitri Karamazov <deserter666@danwin1210.me>
> Cc: ports@openbsd.org <ports@openbsd.org>
> Subject: Re: New port: Gaupol subtitle editor
>  
> Hi,
>
> Many thanks for the comments and fixes. Sure, I can take
> maintainer. So, it looks like I only need to add maintainer
> to your version? Build and package looks ok and runs.
> Any other suggestions?
>
> Thanks,
> Anindya
>
> From: Dimitri Karamazov <deserter666@danwin1210.me>
> Sent: January 28, 2021 9:14 PM
> To: Anindya Mukherjee <anindya49@hotmail.com>
> Cc: ports@openbsd.org <ports@openbsd.org>
> Subject: Re: New port: Gaupol subtitle editor
>  
> On Fri, Jan 29, 2021 at 04:28:50AM +0000, Dimitri Karamazov wrote:
> > Hi, this is a port of gaupol, an editor for text-based subtitle files.
> > It supports multiple subtitle file formats and provides means of
> > creating, editing and translating subtitles and timing subtitles to
> > match video.
> >
> > This is my first port, so there might be things I missed. I have tried
> > to follow the porting guide closely. Please have a look and comment.
> >
> > Thanks,
> > Anindya
>
> I've reattached with some changes
>
> -py-* nomenclature is used for python modules not for standalone ports
>  like this, so I've removed it.
> -FLAVOR{s,} is also used for python modules only, MODPY_VERSION is suffice
>  in this case.
> -rearranged the dependencies in alpha order and added some missing
>  runtime depends.
>
> There are many tests available but most of those need xorg, access to which
> _pbuild doesn't have? One can run them as a normal user though. I'm not sure
> if MODPY_PYTEST is of any use if the tests don't run on their own.
>
> Also I recommended you take maintainer since you're going to use it.
>
> regards,
>   Dimitri

No comments:

Post a Comment