On 2021/04/10 19:09, Stefan Hagen wrote:
> Stuart Henderson wrote:
> > Sample config usually goes in share/examples rather than under doc/.
>
> Thank you, attached the next try with sample config in
> share/examples/notion.
oh, I see, that's actually where it loads from, not just installed as sample?
# Configuration .lua files. Overrideable, as config files are usually
# not placed under $(PREFIX).
-ETCDIR ?= $(PREFIX)/etc/notion
+ETCDIR ?= $(PREFIX)/share/examples/notion
I think what's wanted here is probably to get rid of that patch and set
MAKE_FLAGS= ETCDIR=${SYSCONFDIR}/notion (used during build to tell the
program where to look for files at runtime ) and then FAKE_FLAGS=
ETCDIR=$(PREFIX)/share/examples/notion so fake-install copies the
sample files there. Then use @sample in the PLIST to have pkg_add
copy the files at install time. This is so that the user can modify the
files if needed without causing conflicts.
> I've tried to bring as much work as possible from patches into the
> Makefile. The LUA_VERSION is now also configurable and switches
> library/include paths and flags consistently.
good, that's needed.
> What's a good default here? Notion normally tries to use the highest
> lua version it can find. So I've set it to 5.3. But there's no
> functional loss if we leave it at MODLUA_DEFAULT_VERSION (which
> is 5.1).
Generally best is to set it to prefer whichever upstream prefers. Make sure
it's forced in some way so that e.g. if they normally check in order for
5.4 5.3 5.2 5.1, it won't start picking up 5.4 when that version gets added
to ports.
No comments:
Post a Comment