On Sun, Jun 13, 2021 at 03:40:22PM +0200, Mischa wrote:
> This module implement JSON-RPC 2.0 protocol in transport-independent
> way.
>
> Also it support non-blocking client remote procedure call and both
> blocking and non-blocking server method execution. This can be very
> useful in case server methods will need to do some RPC or other
> slow things like network I/O, which can be done in parallel with
> executing other server methods in any event-based environment.
>
> meta::cpan: https://metacpan.org/pod/JSON::RPC2
>
> JSON RPC is for example needed to use the eAPI from Arista.
>
> Any comments / suggestions welcome!
Most of the other JSON perl modules are in converters, not devel. This
one should probably go there as well.
The COMMENT starts with a capital letter, it shouldn't.
See item #16: http://www.openbsd.org/faq/ports/guide.html#PortsChecklist
Usually perl ports don't need to set BUILD_DEPENDS=${RUN_DEPENDS},
and in this case that seems to be true. It doesn't hurt anything, just
makes bulk builds take slightly longer than than need to.
Something was telling the truth though, as we do need a RUN_DEPENDS on
p5-JSON-Maybe-XS instead of p5-JSON-XS because as it is, `make test`
fails if that isn't installed.
Other than those nits, it looks good to me.
>
> Mischa
>
> PS: Thank you Andrew for your guidance so far!
You're welcome!
I did commit a fix so portgen should properly set the CONFIGURE_STYLE if
p5-Module-Build-Tiny isn't installed and needs to be. Thanks for
reporting that!
l8rZ,
--
andrew - http://afresh1.com
Real programmers don't document.
If it was hard to write, it should be hard to understand.
No comments:
Post a Comment