Friday, October 15, 2021

Re: [new port] games/wordsearch: Classic word search game that you can play in your terminal

Hello Pat --

On 10/15/2021 12:19 AM, Pat Jensen wrote:
> All,
>
> I'm submitting a unified diff of a new port of my console word search
> game for OpenBSD.
>
> Please evaluate and comment on any necessary changes.
>

New ports are usually sent as tarballs. Attached is an improved version
of your port.

Changes:
* Lowercase first letter of COMMENT as is style
* You use 2.0 in both DISTNAME and MASTER_SITES so 2.0 becomes its own
variable, V.
* Tightened up whitespace
* Leaf ports are going to be python 3 by default no need to specify
FLAVOR
* One of your do-install lines was over 80 characters. I was able to
shorten it, but otherwise you'd have to split it over multiple lines
* You want ${INSTALL_DATA_DIR}, not mkdir -p, in your do-install routine
* PLIST changed when I ran `make update-plist`

Works for me on amd64.

~Brian

No comments:

Post a Comment