Monday, October 11, 2021

Re: [update] net/usockets-0.8.1 ,www/uwebsockets-20.5.0, www/purritobin-0.6.7, databases/lmdbxx-1.0.0 (new)

On 2021/10/10 20:42, Brad Smith wrote:
> > -VERSION = 0.6.0
> > -REVISION = 1
> > +VERSION = 0.8.1
> >
> > DISTNAME = usockets-${VERSION}
> > PKGNAME = ${DISTNAME:L}
>
> The PKGNAME here doesn't make sense. DISTNAME is already in all lower case.
>
> > -SHARED_LIBS = usockets 1.0
> > +SHARED_LIBS = usockets 2.0
> >
> > GH_ACCOUNT = uNetworking
> > GH_PROJECT = uSockets
> > -#GH_TAGNAME = v0.6.0
> > -# cstdlib include error
> > -GH_COMMIT = 7683672d87067cd75b854f4e36b9820f4809a4be
> > -
> > +GH_TAGNAME = v0.8.1

bit of duplication going on there, I would go with this in place of all
the above VERSION/DISTNAME/PKGNAME/GH_*, put it up where DISTNAME is now

GH_ACCOUNT = uNetworking
GH_PROJECT = uSockets
GH_TAGNAME = v0.8.1
PKGNAME = ${DISTNAME:L}

No comments:

Post a Comment