Re: Want to submit a port for BadWolf browser

Adnan Shameem <adnan360@protonmail.com> writes:

> Hello
>
> I thought packaging BadWolf, a lightweight, minimalistic,
> privacy-oriented WebKitGTK based web browser for OpenBSD would be
> nice. So I made a port for it (attached).
>
> Please let me know if there are any changes necessary.
>
> Thanks.

couple of comments:

- no need to set EXTRACT_SUFX, is the default

- upstream provides a distribution tarball on their site, so use that
instead of the auto-generated from gitlab

- why use 1.0.3 when the latest is 1.2.0

- *_DEPENDS are usually one per line

- devel/libsoup was missing from LIB_DEPENDS

- missing RDEP on gtk+3

- don't roll our own do-install (and add USE_GMAKE)

- pkg/DESCR is a bit short, it should describe a bit more what the
package is and does, but I'm not a good writer so I've left it as-is,
apologies

- set CONFIGURE_STYLE to simple (how did you managed to build the
port?)

- teach the port the correct place for manpages ($PREFIX/man and not
share/man).

quickly tested and seems to work. A bit spartan maybe, but I like the
buttons to toggle images and javascript.

Note: while there is a test target, I've left the NO_TESTS=Yes because
that target is meant for hacking on the browser itself (it calls mandoc
-Tlint on the manpage and shellcheck on the configure.)

I'm attaching an updated tarball

Cheers,

Omar Polo