Sunday, December 26, 2021

Re: use .tbz: graphics/ocaml-cairo (Re: dune dependant ports should use the right source tarballs)

> On Dec 26, 2021, at 1:10 PM, Yozo TODA <yozo@v007.vaio.ne.jp> wrote:
>
> Yozo TODA writes:
>> graphics/ocaml-cairo still uses "tar.gz" archive and
>> ocamlfind shows (version: n/a).
>
> we don't need patches now because dune is updated, and
> WRKDIST should be overwritten.
> revised updates here.
> (the revision bumped but I'm not sure if it's necessary...)

I've committed two diffs.

First one is your dune diff.

The second commit switches the distfile to the tbz file. Although I did a different diff here which doesn't require an override of WRKDIST.

If it needs more work please let us know. Note that once we have dune 2.8.0 I believe we should not need the tbz releases (although it won't hurt to have them).

A second thing that bothers me with our infrastructure is that we tell people we prefer to use GitHub releases although I'm not sure that our infrastructure supports releases as nicely as it supports tags and specific commits. Would be nice to have something like GH_RELEASE maybe. Dunno.

Thank you for this diff though! Much appreciated.

No comments:

Post a Comment