On 2022/01/03 06:57, wen heping wrote:
> Hi, ports@:
>
> Here is a patch for www/p5-CGI-Simple:
> i) Update to 1.26
> ii) Update DEPENDS
> iii) Update Comments
> iv) Update the version check of www/p5-Catalyst-Runtime
>
> It build well and pass all tests on OpenBSD-current amd64 system.
>
> Five ports depends on it, all build well and pass all tests
> with this patch.
>
> Comments ?
>
>
> wen
> Index: www/p5-CGI-Simple/Makefile
> ===================================================================
> RCS file: /cvs/ports/www/p5-CGI-Simple/Makefile,v
> retrieving revision 1.23
> diff -u -p -r1.23 Makefile
> --- www/p5-CGI-Simple/Makefile 3 Jul 2020 21:45:56 -0000 1.23
> +++ www/p5-CGI-Simple/Makefile 3 Jan 2022 06:44:31 -0000
> @@ -1,17 +1,17 @@
> # $OpenBSD: Makefile,v 1.23 2020/07/03 21:45:56 sthen Exp $
>
> -COMMENT = drop-in object-oriented CGI.pm replacement
> +COMMENT = simple totally OO CGI interface that is CGI.pm compliant
I don't think this change improves things. The old COMMENT is easier to
read and the new one doesn't add any information.
>
> MODULES = cpan
> PKG_ARCH = *
> -DISTNAME = CGI-Simple-1.115
> +DISTNAME = CGI-Simple-1.26
this results in the version number (as understood by ports) going
backwards so will need an EPOCH bump
$ pkg_check-version p5-CGI-Simple-1.115 p5-CGI-Simple-1.26
p5-CGI-Simple-*- sorted: p5-CGI-Simple-1.26 p5-CGI-Simple-1.115
> Index: www/p5-Catalyst-Runtime/Makefile
> ===================================================================
> RCS file: /cvs/ports/www/p5-Catalyst-Runtime/Makefile,v
> retrieving revision 1.30
> diff -u -p -r1.30 Makefile
> --- www/p5-Catalyst-Runtime/Makefile 28 Mar 2021 18:36:25 -0000 1.30
> +++ www/p5-Catalyst-Runtime/Makefile 3 Jan 2022 06:44:31 -0000
> @@ -39,7 +39,7 @@ RUN_DEPENDS= converters/p5-JSON-MaybeXS>
> textproc/p5-String-RewritePrefix>=0.004 \
> textproc/p5-Text-SimpleTable>=0.03 \
> www/p5-CGI-Struct \
> - www/p5-CGI-Simple>=1.109 \
> + www/p5-CGI-Simple>=0 \
Don't use >=0, just remove the version check instead.
A REVISION bump is needed here too.
> www/p5-HTML-Parser \
> www/p5-HTTP-Body>=1.22 \
> www/p5-HTTP-Message>=5.814 \
No comments:
Post a Comment