Re: net/znc - enable cyrus-sasl module and make into multi-package

On 2022/04/27 11:27, Omar Polo wrote:
> > @@ -384,3 +384,4 @@ id user group port
> > 873 _alertmanager _alertmanager sysutils/alertmanager
> > 874 _snowflakeproxy _snowflakeproxy net/snowflake_proxy
> > 875 _guacd _guacd net/guacamole/server
> > +876 _znc _znc net/znc
>
> (it's just me or we're adding a lot of users recently?)

not particularly... a lot of these are just for privdrop and don't even
need to own any files in the package, so there doesn't seem much good
reason for them to use a fixed id.

$ for i in OPENBSD_6_{0,1,2,3,4,5,6,7,8,9} OPENBSD_7_{0,1}; do echo $i `acvs up -r $i -p user.list | wc -l`; done
OPENBSD_6_0 290
OPENBSD_6_1 299
OPENBSD_6_2 304
OPENBSD_6_3 315
OPENBSD_6_4 329
OPENBSD_6_5 343
OPENBSD_6_6 355
OPENBSD_6_7 365
OPENBSD_6_8 370
OPENBSD_6_9 376
OPENBSD_7_0 380
OPENBSD_7_1 385

> > -WANTLIB= c crypto icuuc icudata m pthread ssl z ${COMPILER_LIBCXX}
> > +MULTI_PACKAGES= -main -sasl
> > +PSEDUO_FLAVORS= no_sasl

typo ^^^^^^ btw

> > NO_TEST= Yes
> >
> > .include <bsd.port.mk>
> > +
> > +.if !${BUILD_PACKAGES:M-sasl}
> > +CONFIGURE_ARGS+= -DWANT_CYRUS=NO
> > +.endif

this is to go with pseudo flavours. If that's kept then it should
go after a new .include <bsd.port.arch.mk> rather than after
.include <bsd.port.mk>.

> for updates to work. If I've understood everything correctly, by
> splitting this into a subpackage the pkgpath changed from net/znc to
> net/znc,-main so for smooth upgrade you need a @pkgpath here.

yep

> > index 00000000000..55bf39e73dd
> > --- /dev/null
> > +++ b/net/znc/pkg/README-main
> > @@ -0,0 +1,12 @@
> > ++--------------------------
> > ++ Running ZNC on OpenBSD
> > ++--------------------------
>
> should read
>
> Running ${PKGSTEM} on OpenBSD
>
> and the '--' long as per infrastructure/template/README.template, but I
> guess it doesn't matter too much.

yes, please follow the README.template format for consistency.