Hi Omar,
Many thanks for your feedback and corrections, I have added myself as the
maintainer of this port, and regenerated the tar.gz.
Let me know the further actions.
Best regards,
Salil
On Mon, Apr 25, 2022 at 2:18 AM Omar Polo <op@openbsd.org> wrote:
> Hello,
>
> Salil Wadnerkar <bsdprg@gmail.com> wrote:
> > Hi,
> >
> > qpdfview (https://launchpad.net/qpdfview) is a tabbed document viewer.
> It
> > uses Poppler for PDF support, libspectre for PS support, DjVuLibre for
> DjVu
> > support, CUPS for printing support and the Qt toolkit for its interface.
> > I am using it as my daily pdf reader. And I have tested it locally with
> ps,
> > djvu files as well.
> > Please review the port request.
>
> it's a good start ;)
>
> There are a couple of things that can be improved:
>
> - nitpicking: the pkg/DESCR file is usually formatted, so lines are not
> longer than ~72 chars (it really depends, but that's the idea)
>
> - nitpicking: indentation. We usually use tabs (with a width of 8) to
> align the variables.
>
> - the variable MAINTAINER is not the upstream developer, but an OpenBSD
> user that's maintaining the *port* (not the project)
>
> - `make port-lib-depends-check' reports that the WANTLIBs are not
> correct:
>
> % make port-lib-depends-check
> qpdfview-0.4.18(textproc/qpdfview):
> Missing lib: synctex.3 (/usr/local/bin/qpdfview) (NOT REACHABLE)
> Extra: z.6
> *** Error 1 in target 'port-lib-depends-check' (ignored)
>
> This means that `z' is extra and the port that provides the `synctex'
> (print/texlive/base,-synctex) shared library is not listed in
> LIB_DEPENDS.
>
> - /usr/ports/infrastructure/bin/portcheck says that it's missing an
> RDEP on x11/gtk+3,-guic
>
> - another nitpicking: usually the *_DEPENDS and MODULES values are
> sorted.
>
> I've fixed these in the attached tarball: with these fixes it looks fine
> to be. That said I'm a little hesintat to import something that hasn't
> been updated in the last ten years...
>
> > Best regards,
> > Salil
>
>
No comments:
Post a Comment